20260515 cse dominance trick#485
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bed807f. Configure here.
| if stepping < 26 { | ||
| dialect.stepping = Some(26); | ||
| } | ||
| dialect.cse_dominance = true; |
There was a problem hiding this comment.
Redundant CSE dominance assignment
Low Severity
The new dialect.cse_dominance = true inside the if let Some(stepping) block is a dead store. cse_dominance is already set to true unconditionally just above, so this assignment never changes behavior and only duplicates the existing enablement for modules.
Reviewed by Cursor Bugbot for commit bed807f. Configure here.


Note
Low Risk
Single redundant dialect flag assignment in module compile setup; no auth or I/O changes, and behavior should match the prior unconditional
cse_dominance = trueunless future stepping logic alters the dialect.Overview
Module compilation now sets
dialect.cse_dominance = trueagain inside thesteppingbranch ofmodule_compile_opts, in addition to the existing unconditional enable at the start of that helper.That flag switches the CSE optimizer to the corrected dominance rules (see
before_cse_dominance_fixincse.rs) instead of the legacyif-branch overlap behavior. The change is scoped to chialisp module builds, which already forceint_fix, optimization, and a minimum stepping of 26 when stepping is present.Reviewed by Cursor Bugbot for commit bed807f. Bugbot is set up for automated code reviews on this repo. Configure here.