Config Actions: Wire nd_manage_switches to the Common Save and Deploy Framework - #499
Open
AKDRG wants to merge 9 commits into
Open
Config Actions: Wire nd_manage_switches to the Common Save and Deploy Framework#499AKDRG wants to merge 9 commits into
AKDRG wants to merge 9 commits into
Conversation
AKDRG
requested review from
akinross,
allenrobel,
anvitha-jain,
gmicol,
lhercot,
mikewiebe,
mtarking,
sajagana,
samiib and
shrsr
as code owners
August 10, 2026 08:35
…n' into config_actions_switches_integration
allenrobel
reviewed
Aug 10, 2026
allenrobel
left a comment
Collaborator
There was a problem hiding this comment.
Code review
Reviewed the switch-module wiring into the common config-actions framework (findings in the config_actions/ package itself are out of scope here since they land via #498). Two findings, posted inline.
🤖 Generated with Claude Code
8 tasks
allenrobel
approved these changes
Aug 25, 2026
allenrobel
left a comment
Collaborator
There was a problem hiding this comment.
Verified 8327cd91 addresses both threads: finalize() now fails on switch-scoped deploy with no targets, and _idempotent_sync_serials() fails early naming any out-of-sync switch without a resolved switchId. Unit tests pass locally (39 passed). LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Related to #368
Merge dependency on common framework #498
Proposed Changes
nd_manage_switchesinto the sharedconfig_actionsframework.config_actionsthrough the common policy-driven parser.config_actions.save: trueconfig_actions.deploy: trueconfig_actions.type: switchconfig_actions: {}deploy: truewithsave: falseconfig_actions.deployis enabled.Test Notes
Ran formatting:
black --check -l 159 plugins testsRan targeted sanity checks:
ansible-test sanity --test pep8 --color --truncate 0ansible-test sanity --test pylint --color --truncate 0Ran full sanity from a materialized collection tree:
ansible-test sanity --color --truncate 0Live tested switch config actions on
AK-VXLAN:Cisco Nexus Dashboard Version
Cisco Nexus Dashboard 4.2.1
Related ND API Resource Category
Checklist