feat: implement param binding for binary strings and UUIDs#61
Open
abonander wants to merge 7 commits into
Open
feat: implement param binding for binary strings and UUIDs#61abonander wants to merge 7 commits into
abonander wants to merge 7 commits into
Conversation
397f35a to
4615abc
Compare
4615abc to
a6f884c
Compare
and test `Binary` as string
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the ClickHouse ADBC driver’s parameter binding and Arrow schema interoperability by adding support for binary string parameters and UUID (via the arrow.uuid extension type), and by exposing a driver option that maps to ClickHouse’s output_format_arrow_string_as_string setting.
Changes:
- Bind Arrow
Binary/LargeBinary/FixedSizeBinary/BinaryViewparameters as ClickHouse byte strings viaserde_bytes. - Recognize
FixedSizeBinary(16)+arrow.uuidmetadata and bind as ClickHouse UUID parameters. - Add
clickhouse.client.output_string_as_stringoption and an integration test covering UUID + binary round-trips.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/statement.rs |
Adds binary/UUID parameter binding logic and uses ClickHouse settings for query/session IDs and output format. |
src/options.rs |
Introduces OUTPUT_STRING_AS_STRING option and as_setting constants for server-side setting names. |
src/lib.rs |
Switches to set_setting and wires connection-level options to server settings (contains a session-id mapping bug). |
tests/it/params.rs |
Adds integration coverage for UUID + binary string parameter binding and round-trip output. |
tests/it/main.rs |
Registers the new params integration test module. |
Cargo.toml / Cargo.lock |
Adds serde_bytes and uuid dependencies required for new binding behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ecb5317 to
4ad6556
Compare
4ad6556 to
75943e1
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arrow.uuidextension type as a literal UUID.clickhouse.client.output_string_as_stringoption to map tooutput_format_arrow_string_as_stringsetting.fixes #3
fixes #32
Checklist
Delete items not relevant to your PR: