Skip to content

Use double buffering when downloading with progress #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lostmsu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use double buffering when downloading with progress #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/Internals/HttpClientDownloadHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,24 +57,30 @@ public static async Task DownloadFileAsync(
var bufferSize = (contentLength == -1 || contentLength > DefaultDownloadBufferLength)
? DefaultDownloadBufferLength
: contentLength;
var copyBuffer = new byte[bufferSize];
var readBuffer = new byte[bufferSize];
var writeBuffer = new byte[bufferSize];
var writeSlice = new ArraySegment<byte>(writeBuffer, 0, 0);

long totalRead = 0;
while (true)
{
if (cancellationToken.IsCancellationRequested)
return;
cancellationToken.ThrowIfCancellationRequested();

int bytesRead = await download.ReadAsync(
copyBuffer,
var writing = destination.WriteAsync(writeSlice.Array!, writeSlice.Offset, writeSlice.Count);

var reading = download.ReadAsync(
readBuffer,
0,
copyBuffer.Length)
.ConfigureAwait(false);
readBuffer.Length);

await Task.WhenAll(writing, reading);
int bytesRead = await reading;

if (bytesRead == 0)
break;

await destination.WriteAsync(copyBuffer, 0, bytesRead).ConfigureAwait(false);
writeSlice = new(readBuffer, 0, bytesRead);
(readBuffer, writeBuffer) = (writeBuffer, readBuffer);

totalRead += bytesRead;
progress?.Report(new ByteProgress(contentLength, totalRead));
Expand Down