feat(run): support simulation for free-threaded python #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for free-threaded Python builds by conditionally setting the PYTHONMALLOC environment variable. Free-threaded Python (with GIL disabled) manages memory differently and does not support PYTHONMALLOC=malloc, so the code now detects this configuration and skips setting the environment variable when appropriate.
Key Changes:
- Introduced a new helper function to detect free-threaded Python builds via
sysconfig.get_config_var('Py_GIL_DISABLED') - Modified the measurement setup to conditionally set
PYTHONMALLOC=malloconly for non-free-threaded Python
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/run/runner/valgrind/measure.rs | Updated to conditionally set PYTHONMALLOC environment variable based on Python build type |
| src/run/runner/valgrind/helpers/python.rs | New module with detection logic for free-threaded Python builds |
| src/run/runner/valgrind/helpers/mod.rs | Added python module export |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove PYTHONMALLOC=malloc which is unsupported for free-threaded builds
adriencaccia
force-pushed
the
feat/free-threaded-python
branch
from
2279f5e to
5954ffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PYTHONMALLOC=malloc which is unsupported for free-threaded builds
Needed for CodSpeedHQ/pytest-codspeed#96 to land