Skip to content

212 project page#218

Merged
mehanana merged 5 commits into
mainfrom
212-project-page
Jun 2, 2026
Merged

212 project page#218
mehanana merged 5 commits into
mainfrom
212-project-page

Conversation

@mehanana

@mehanana mehanana commented May 26, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Issue

Closes #212

📝 Description

Created a page for a single project

Briefly list the changes made to the code:

  1. Created the project page using the figma design
  2. Extracted the expenses table from the expenses page into its own component
  3. Used the ExpenseTable component in the expenses page and the project page
  4. Connected the project page to the backend/db to retrieve data for it
  5. Made a change in the projects members route to match both /projects/{id}/members and /{id}/members to handle dev server path prefix stripping
  6. In apps/frontned/next.config.ts, replaced the catch-all /projects/:path* rule with ones for /members, /expenditures, and /donors sub-routes so that /projects/:id renders the page instead of the backend
  7. Wrote tests for the new projects page and also checked if all other tests passed

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.

Project page (newly implemented):
Screenshot 2026-05-25 200358

Expense Page (to show it still looks good):
Screenshot 2026-05-25 192554

All frontend tests (including new ones made for Project page):
Screenshot 2026-05-25 193323

Backend tests for projects endpoint:
Screenshot 2026-05-25 194147

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!
I saw that the expenses page had the backend connected to it, and so I did that for this project page as well. But I saw that the donors and donations pages weren't connected yet, and I'm not sure if there's already a ticket for this but just wanted to bring that up!

mehanana added 4 commits May 25, 2026 19:43
and /{id}/members to handle dev server path prefix stripping
…/expenditures, and /donors sub-routes so that /projects/:id renders the page instead of the backend
@mehanana
mehanana requested a review from nourshoreibah as a code owner May 26, 2026 00:01
@github-actions
github-actions Bot requested a review from tsudhakar87 May 26, 2026 00:01
github-actions Bot added a commit that referenced this pull request May 26, 2026

@nourshoreibah nourshoreibah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for abstracting the expenses table

@tsudhakar87 tsudhakar87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

github-actions Bot added a commit that referenced this pull request Jun 2, 2026
@mehanana
mehanana added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit d67a38f Jun 2, 2026
15 checks passed
@mehanana
mehanana deleted the 212-project-page branch June 2, 2026 22:48
github-actions Bot added a commit that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the projects page

3 participants