NVMe MI / Configuration {Get,Set} #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Configuration Get support snuck in during 5c6d725 ("nvme: mi: Convert to deku"). I used these commands to experiment with deku itself, and then must have done some over-enthusiastic squashing when tidying up the change history. In the process, fix the implementation of NVMe MI / Configuration Get / MCTP Transmission Unit Size. The conversion to enum-based parsing makes measuring from the buffer start a tricky prospect, and incorrect in this case. Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Implementing RequestHandler on the struct allows reuse of the NvmeMiConfigurationIdentifierRequestType enum for Configuration Set. Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Primarily, organise structs and enum definitions such that: - The library data model is defined in src/lib.rs - Base specification details are contained in src/nvme.rs - MI specification details are contained in src/nvme/mi.rs - The device implementation src/nvme/mi/dev.rs In the process, drop the use of num-traits in favour of the Discriminant trait. Signed-off-by: Andrew Jeffery <[email protected]>
Many NVMe-MI commands change device state in ways that only the implementing application can handle, as they require either reconfiguring lower layers of the stack or persisting state. NVMe MI / Configuration Set / MCTP Transmission Unit Size motivates the change. Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for Configuration Get and Configuration Set. Along the way, reorganise the codebase and implement an interface to propagate command effects to the application.