Smart log #4
Merged
Smart log #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: this `if` statement can be collapsed
--> src/wire/vec.rs:48:5
|
48 | / if let Some(cap) = capacity {
49 | | if cap > S {
50 | | return Err(deku_error!(
51 | | DekuError::InvalidParam,
... |
58 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `-D clippy::collapsible-if` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`
help: collapse nested if block
|
48 ~ if let Some(cap) = capacity
49 ~ && cap > S {
50 | return Err(deku_error!(
...
56 | ));
57 ~ }
|
Signed-off-by: Andrew Jeffery <[email protected]>
Make sure at least all rust source files are populated. After the
change:
$ comm -23 <(git ls-files | sort) <(git grep -l SPDX-License-Identifier | sort)
Cargo.lock
Cargo.toml
.github/workflows/main.yml
.gitignore
LICENSE
README.md
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Signed-off-by: Andrew Jeffery <[email protected]>
Now that we have the full request parse from deku there's no need to explicitly log the substructure state. Signed-off-by: Andrew Jeffery <[email protected]>
Rename it to AdminIoCqeStatusType in the process of adding AdminIoCqeStatus, on which we implement From<_> for u32 to achieve the isolation. Signed-off-by: Andrew Jeffery <[email protected]>
Move the implementation to a free-standing function so it can be used across both AdminIdentifyRequest and AdminGetLogPageRequest. Signed-off-by: Andrew Jeffery <[email protected]>
…ion Log Page Signed-off-by: Andrew Jeffery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.