fix(reports): add scoped error boundary - #1239
Merged
Merged
Conversation
Contributor
|
@Kandexa is attempting to deploy a commit to the Mftee's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Kandexa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
mftee
approved these changes
Aug 26, 2026
mftee
left a comment
Contributor
There was a problem hiding this comment.
No merge conflicts with main. Scoped error boundary for reports is a solid fix - approving.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1166
Closes #1168
Closes #1169
Closes #1167
Adds the missing reports-level error boundary with a reports-specific retry action and dashboard navigation. This keeps a failed reports fetch within the reports segment instead of using the broader protected-layout fallback.
Why
The reports route had a loading boundary but no matching error boundary, so a reports-only data failure could surface through a generic protected-route error. A nested
error.tsxuses the existing App Router boundary pattern and gives users a retry path local to the failed segment.What was built
frontend/app/[locale]/(protected)/reports/error.tsxreset()for retry, and links back to the dashboard.frontend/test-utils/reports-error.test.tsxIntegration changes outside
frontend/app/[locale]/(protected)/reports/No existing production files modified; the route boundary and its test are additions only.
Acceptance criteria coverage
frontend/app/[locale]/(protected)/reports/error.tsxplusfrontend/test-utils/reports-error.test.tsx— scoped heading and retry callback)Deliberately deferred
None.
Test plan
npm test— not run per requestnpm run typecheck— not run per requestnpm run lint— not run per requestnpm run build— not run per requestEnv vars / Notes
No new environment variables or public API surfaces. The parent protected error boundary remains unchanged for failures outside the reports segment.