fix(ci): check R2 when --version is provided to gap detector #232
+24
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, --version bypassed the R2 check entirely and output all 6 platforms unconditionally. This caused unnecessary build attempts for platforms that already have binaries in R2 (e.g., Windows via RubyInstaller). Now --version checks R2 when credentials are available and only outputs platforms that are actually missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--versionis provided with R2 credentials, the gap detector now checks R2 for existing builds and only outputs platforms that are actually missing--versionstill falls back to outputting all platforms (for local testing)--versionis setThis prevents unnecessary build attempts for platforms that already have binaries in R2 (e.g., Windows builds from RubyInstaller).
Test plan
version: 3.2.10and verify Windows platforms are excluded from the matrix (since RubyInstaller builds already exist in R2)--version=3.2.10(no R2 creds) and verify all platforms are output as fallback