Cache background URLs for instant background on game switch - #896
Merged
Conversation
shatyuka
marked this pull request as ready for review
July 22, 2026 16:01
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+134
to
+138
| bool willDisplayStatic = !IsVideoMediaFileExtensionSupported(primaryBg ?? staticBgUrl!) || | ||
| (!CurrentIsEnableCustomImage && | ||
| !GlobalIsEnableCustomImage && | ||
| !CurrentIsEnableBackgroundAutoPlay); | ||
| Uri accentPreviewUri = willDisplayStatic ? new Uri(localStatic) : new Uri(localBackground); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
+379
to
+383
| Color syncColor = Task.Run(async () => | ||
| await ColorPaletteUtility.GetMediaAccentColorFromAsync(fallbackSourceUri, false) | ||
| ).GetAwaiter().GetResult(); | ||
| ThemeRootElement.ChangeAccentColor(syncColor); | ||
| LauncherConfig.SetAndSaveConfigValue($"{cachedBgKey}-AccentColor", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| ImageSource = new BitmapImage(new Uri(placeholderPath)), | ||
| Stretch = Stretch.UniformToFill | ||
| }; | ||
| PresenterGrid.Children.Clear(); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
neon-nyan
approved these changes
Aug 1, 2026
Merged
neon-nyan
added a commit
that referenced
this pull request
Aug 25, 2026
 # Preview 1.84.5 (Codename: Columbina) # What's Changed? - 1.84.5 - **[Imp]** [Optimize background image load](#891), by @shatyuka - **[Imp]** [Cache background URLs for instant background on game switch](#896), by @shatyuka - **[Imp]** [Fix drag mechanism in Plugin Management Menu](#894), by @Cryotechnic - **[Misc]** [docs: fix broken links in Thai localized README](#898), by @latent-9 - **[Imp]** [Reconciling progress state](5103e5d), by @Cryotechnic - **[Imp]** [Use Async API for Honkai Impact 3rd's Game Repair](6cecd09) - **[Fix]** #895 [Fix False "insufficient space" error on NTFS volume mount points](0d472e9), by @shatyuka - **[Imp]** [Skip cps value validation](63f7d7c), by @shatyuka - **[Fix][Imp]** Bunch of Windows App SDK fixes and improvements, by @shatyuka and @neon-nyan - [Fix maximize disable not working after AOT](2579160) - [Fix trim in non-AOT mode](5f6273f) - [Fix NativeAOT Debug build freeze](5d610db) - [Enable Windows App SDK experimental optimizations](46a8241), [See Microsoft Documentation here](https://github.com/sundaramramaswamy/microsoft-ui-xaml/blob/069fbc9683b3b07df5549961e00251439a6916cd/specs/XamlOptionalChanges/XamlOptionalChanges-Spec.md#xamlchangeid-enum) for more info. - [Fix crash due to unnecessary assertion in generated code](6474dd8) - **[Fix]** [Fix preload package detection](d1d9f70), by @neon-nyan - **[Fix]** [Fix Sophon force redirect logic](92f49be), by @neon-nyan - **[Imp]** Upgrade FFmpeg to 8.x + Includes in-house, LGPLv2.1 compliance library with the build, by @neon-nyan - **[Imp]** CI/CD Workflows and Pipelines, by @bagusnl **Full Changelog**: CL-v1.84.4-pre...CL-v1.84.5-pre # Code Signing Policy > Free code signing provided by [SignPath.io], certificate by [SignPath Foundation] - This program will not transfer any information to other networked systems. - Read our full [**Privacy Policy**](https://github.com/CollapseLauncher/Collapse/blob/main/PRIVACY.md) - Also read our [**Third Party Notices**](https://github.com/CollapseLauncher/Collapse/blob/main/THIRD_PARTY_NOTICES.md) for license used by third party libraries that we use. [SignPath Foundation]:https://signpath.org [SignPath.io]:https://signpath.io
Merged
neon-nyan
added a commit
that referenced
this pull request
Aug 25, 2026
 # Preview 1.84.5 (Codename: Columbina) # What's Changed? - 1.84.5 - **[Imp]** [Optimize background image load](#891), by @shatyuka - **[Imp]** [Cache background URLs for instant background on game switch](#896), by @shatyuka - **[Imp]** [Fix drag mechanism in Plugin Management Menu](#894), by @Cryotechnic - **[Misc]** [docs: fix broken links in Thai localized README](#898), by @latent-9 - **[Imp]** [Reconciling progress state](5103e5d), by @Cryotechnic - **[Imp]** [Use Async API for Honkai Impact 3rd's Game Repair](6cecd09) - **[Fix]** #895 [Fix False "insufficient space" error on NTFS volume mount points](0d472e9), by @shatyuka - **[Imp]** [Skip cps value validation](63f7d7c), by @shatyuka - **[Fix][Imp]** Bunch of Windows App SDK fixes and improvements, by @shatyuka and @neon-nyan - [Fix maximize disable not working after AOT](2579160) - [Fix trim in non-AOT mode](5f6273f) - [Fix NativeAOT Debug build freeze](5d610db) - [Enable Windows App SDK experimental optimizations](46a8241), [See Microsoft Documentation here](https://github.com/sundaramramaswamy/microsoft-ui-xaml/blob/069fbc9683b3b07df5549961e00251439a6916cd/specs/XamlOptionalChanges/XamlOptionalChanges-Spec.md#xamlchangeid-enum) for more info. - [Fix crash due to unnecessary assertion in generated code](6474dd8) - **[Fix]** [Fix preload package detection](d1d9f70), by @neon-nyan - **[Fix]** [Fix Sophon force redirect logic](92f49be), by @neon-nyan - **[Imp]** Upgrade FFmpeg to 8.x + Includes in-house, LGPLv2.1 compliance library with the build, by @neon-nyan - **[Imp]** CI/CD Workflows and Pipelines, by @bagusnl **Full Changelog**: CL-v1.84.4-pre...CL-v1.84.5-pre # Code Signing Policy > Free code signing provided by [SignPath.io], certificate by [SignPath Foundation] - This program will not transfer any information to other networked systems. - Read our full [**Privacy Policy**](https://github.com/CollapseLauncher/Collapse/blob/main/PRIVACY.md) - Also read our [**Third Party Notices**](https://github.com/CollapseLauncher/Collapse/blob/main/THIRD_PARTY_NOTICES.md) for license used by third party libraries that we use. [SignPath Foundation]:https://signpath.org [SignPath.io]:https://signpath.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Goal
Cache background image URLs to config and preload background before region loading, so the cached or preset background appears instantly on game switch without waiting for API download.
If the background files are cached locally, the background is displayed immediately. If not cached, the game-specific preset placeholder is shown while the real background downloads in the background.
Games added via plugins have not yet been tested.
PR Status :