Preview 1.84.5

.github/workflows/build.yml

@@ -41,7 +41,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v7
       with:
         submodules: recursive
 
@@ -54,7 +54,7 @@ jobs:
         }
 
     - name: Install .NET
-      uses: actions/setup-dotnet@v4
+      uses: actions/setup-dotnet@v6
       with:
         dotnet-version: ${{ env.DOTNET_VERSION }}
         dotnet-quality: ${{ env.DOTNET_QUALITY }}
@@ -69,7 +69,7 @@ jobs:
         dotnet publish CollapseLauncher -c ${{matrix.Configuration}} -p:PublishProfile=Publish-DebugCIRelease -p:PublishDir=".\debug-build\" -p:PublishAot=false
 
     - name: Upload Artifact
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
           name: collapse_${{ matrix.platform }}-${{ matrix.configuration }}_${{ matrix.framework }}_${{ github.sha }}
           path: ./CollapseLauncher/debug-build/
@@ -97,7 +97,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v7
       with:
         submodules: recursive
 
@@ -110,7 +110,7 @@ jobs:
         }
 
     - name: Install .NET
-      uses: actions/setup-dotnet@v4
+      uses: actions/setup-dotnet@v6
       with:
         dotnet-version: ${{ env.DOTNET_VERSION }}
         dotnet-quality: ${{ env.DOTNET_QUALITY }}
@@ -125,7 +125,7 @@ jobs:
         dotnet publish CollapseLauncher -c ${{matrix.Configuration}} -p:PublishProfile=Publish-DebugCIReleaseAOT -p:PublishDir=".\debug-aot-build\" -p:PublishAotSelf=true
 
     - name: Upload debug symbols
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
         name: aot-experimental-symbols_collapse_${{ matrix.platform }}-${{ matrix.configuration }}_${{ matrix.framework }}_${{ github.sha }}
         path: ./CollapseLauncher/debug-aot-build/**/*.pdb
@@ -136,7 +136,7 @@ jobs:
         Remove-Item -Path "./CollapseLauncher/debug-aot-build/*.pdb" -Recurse -Force
 
     - name: Upload Artifact
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
             name: aot-experimental_collapse_${{ matrix.platform }}-${{ matrix.configuration }}_${{ matrix.framework }}_${{ github.sha }}
             path: ./CollapseLauncher/debug-aot-build/
@@ -148,7 +148,7 @@ jobs:
     needs: [build, build-nativeaot]
     steps:
     - name: Notify Discord
-      uses: sarisia/actions-status-discord@v1.15.1
+      uses: sarisia/actions-status-discord@v1.16
       if: always()
       continue-on-error: true
       with:

.github/workflows/dd-static-analysis.yml

@@ -14,11 +14,13 @@ jobs:
 
       - name: Check code meets quality and security standards
         id: datadog-static-analysis
-        uses: DataDog/datadog-static-analyzer-github-action@v1
+        uses: DataDog/datadog-static-analyzer-github-action@v3
         with:
           dd_api_key: ${{ secrets.DD_API_KEY }}
           dd_app_key: ${{ secrets.DD_APP_KEY }}
           dd_site: ap1.datadoghq.com
           secrets_enabled: false
           static_analysis_enabled: true
-          cpu_count: 2
+          cpu_count: 4
+          diff_aware: true
+          enable_performance_statistics: true

.github/workflows/qodana-scan-pr.yml

@@ -33,7 +33,7 @@ jobs:
     steps:
     # skip all the steps if the head repo is not the same as the main repo
     # https://github.com/orgs/community/discussions/26829#discussioncomment-3253575
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v7
         if: ${{ github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name }}
         with:
             ref: ${{ github.event.pull_request.head.sha }}  # to check out the actual pull request commit, not the merge commit
@@ -49,7 +49,7 @@ jobs:
           }
 
       - name: Install .NET
-        uses: actions/setup-dotnet@v4
+        uses: actions/setup-dotnet@v6
         with:
           dotnet-version: ${{ env.DOTNET_VERSION }}
           dotnet-quality: ${{ env.DOTNET_QUALITY }}

.github/workflows/qodana-scan.yml

@@ -28,7 +28,7 @@ jobs:
       checks: write
       security-events: write
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v7
         with:
           ref: ${{ github.event.pull_request.head.sha }}  # to check out the actual pull request commit, not the merge commit
           submodules: recursive # many many submodules
@@ -42,7 +42,7 @@ jobs:
           }
 
       - name: Install .NET
-        uses: actions/setup-dotnet@v4
+        uses: actions/setup-dotnet@v6
         with:
           dotnet-version: ${{ env.DOTNET_VERSION }}
           dotnet-quality: ${{ env.DOTNET_QUALITY }}

.github/workflows/release-signed.yml

@@ -69,7 +69,7 @@ jobs:
           echo "::notice::Signing Policy: $env:SIGNING_POLICY_SLUG"
 
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v7
       with:
         submodules: recursive
 
@@ -82,7 +82,7 @@ jobs:
         }
 
     - name: Install .NET
-      uses: actions/setup-dotnet@v4
+      uses: actions/setup-dotnet@v6
       with:
         dotnet-version: ${{ env.DOTNET_VERSION }}
         dotnet-quality: ${{ env.DOTNET_QUALITY }}
@@ -112,14 +112,14 @@ jobs:
 
     - name: Upload Artifact (unsigned)
       id: upload-unsigned-artifact
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
           name: collapse-v${{ env.VERSION }}_${{ env.SIGNING_POLICY_SLUG }}-${{ env.CONFIGURATION_STRATEGY }}_${{ env.PUBLISH_PROFILE }}
           path: ./CollapseLauncher/SignArtifact
           compression-level: 9
 
     - name: Notify Discord for pending build
-      uses: sarisia/actions-status-discord@v1.15.3
+      uses: sarisia/actions-status-discord@v1.16
       if: always()
       continue-on-error: true
       with:
@@ -173,14 +173,14 @@ jobs:
         }
 
     - name: Re-upload Signed Artifact to GitHub
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
           name: SIGNED_collapse-v${{ env.VERSION }}_${{ env.SIGNING_POLICY_SLUG }}-${{ env.CONFIGURATION_STRATEGY }}_${{ env.PUBLISH_PROFILE }}
           path: ${{ runner.temp }}/SignedArtifact
           compression-level: 9
 
     - name: Final Notify Discord
-      uses: sarisia/actions-status-discord@v1.15.3
+      uses: sarisia/actions-status-discord@v1.16
       if: always()
       continue-on-error: true
       with:
@@ -194,7 +194,7 @@ jobs:
           Click [here](https://nightly.link/CollapseLauncher/Collapse/actions/runs/${{ github.run_id }}) to download!
 
     - name: Install Sentry CLI
-      uses: MinoruSekine/setup-scoop@v4.0.1
+      uses: MinoruSekine/setup-scoop@v5.0.1
       with:
         buckets: extras
         apps: sentry-cli
@@ -229,7 +229,7 @@ jobs:
             }
 
     - name: Attest Build Provenance
-      uses: actions/attest-build-provenance@v3
+      uses: actions/attest-build-provenance@v4
       with:
         subject-path: "${{ runner.temp }}/SignedArtifact/BuildArtifact-${{ env.VERSION }}/**"
 

CollapseLauncher/Classes/CachesManagement/Honkai/Fetch.cs

@@ -91,20 +91,19 @@ private async Task BuildGameRepoURL(HttpClient client, CancellationToken token)
             KianaDispatch dispatch = null;
             Exception lastException = null;
 
-            PresetConfig presetConfig = GameVersionManager.GamePreset;
+            PresetConfig presetConfig = GameVersionManager!.GamePreset!;
             int[]        version      = GameVersion.VersionArray;
             string       key          = presetConfig.DispatcherKey ?? "";
 
+            if (string.IsNullOrEmpty(presetConfig.DispatcherKey))
+            {
+                throw new NullReferenceException("Dispatcher key is null or empty!");
+            }
+
             foreach (string baseURL in presetConfig.GameDispatchArrayURL ?? [])
             {
                 try
                 {
-                    // Init the key and decrypt it if existed.
-                    if (string.IsNullOrEmpty(GameVersionManager.GamePreset.DispatcherKey))
-                    {
-                        throw new NullReferenceException("Dispatcher key is null or empty!");
-                    }
-
                     // Try assign dispatcher
                     if (presetConfig is { GameDispatchURLTemplate: not null, GameDispatchChannelName: not null })
                         dispatch = await KianaDispatch.GetDispatchAsync(client,
@@ -129,7 +128,7 @@ private async Task BuildGameRepoURL(HttpClient client, CancellationToken token)
 
             // Get gatewayURl and fetch the gateway
             GameGateway = await KianaDispatch.GetGameServerAsync(client,
-                                                                 dispatch,
+                                                                 dispatch!,
                                                                  presetConfig.GameGatewayDefault!,
                                                                  key,
                                                                  version,

CollapseLauncher/Classes/Extension/UIElementExtensions.ThemeExtensions.cs

@@ -15,6 +15,13 @@ public static partial class UIElementExtensions
 
         public static void ChangeAccentColor(this FrameworkElement element, Color baseColor)
         {
+            if (Application.Current.Resources.TryGetValue("AccentColor", out object? existing) &&
+                existing is SolidColorBrush existingBrush &&
+                existingBrush.Color.Equals(baseColor))
+            {
+                return;
+            }
+
             Color accentColorMask        = baseColor;
             Color accentColorTransparent = baseColor;
 
@@ -55,30 +62,28 @@ public static void ChangeAccentColor(this FrameworkElement element, Color baseCo
 
         internal static void ReloadPageTheme(this FrameworkElement page)
         {
-            ElementTheme theme = InnerLauncherConfig.CurrentAppTheme switch
+            ElementTheme target = InnerLauncherConfig.CurrentAppTheme switch
                                  {
                                      AppThemeMode.Dark => ElementTheme.Dark,
                                      AppThemeMode.Light => ElementTheme.Light,
                                      _ => ElementTheme.Default
                                  };
 
+            // Force the opposite theme first to ensure ThemeResource re-evaluation.
+            ElementTheme opposite = target switch
+            {
+                ElementTheme.Dark  => ElementTheme.Light,
+                ElementTheme.Light => ElementTheme.Dark,
+                _                  => ElementTheme.Light
+            };
+
             bool isComplete = false;
             while (!isComplete)
             {
                 try
                 {
-                    page.RequestedTheme = page.RequestedTheme switch
-                                          {
-                                              ElementTheme.Dark => ElementTheme.Light,
-                                              ElementTheme.Light => ElementTheme.Default,
-                                              ElementTheme.Default => ElementTheme.Dark,
-                                              _ => page.RequestedTheme
-                                          };
-
-                    if (page.RequestedTheme != theme)
-                    {
-                        ReloadPageTheme(page);
-                    }
+                    page.RequestedTheme = opposite;
+                    page.RequestedTheme = target;
 
                     isComplete = true;
                 }

CollapseLauncher/Classes/Extension/UIElementExtensions.cs

@@ -543,9 +543,6 @@ internal static ref TReturnType GetApplicationResourceRef<TReturnType>(string re
 
         internal static void SetApplicationResource(string resourceKey, object value)
         {
-            if (!CurrentResourceDictionary.ContainsKey(resourceKey))
-                throw new KeyNotFoundException($"Application resource with key: {resourceKey} does not exist!");
-
             CurrentResourceDictionary[resourceKey] = value;
         }
 

CollapseLauncher/Classes/FileMigrationProcess/IO.cs

@@ -3,6 +3,7 @@
 using CollapseLauncher.XAMLs.Theme.ContentDialog;
 using Hi3Helper;
 using Hi3Helper.Data;
+using Hi3Helper.Win32.ManagedTools;
 using Microsoft.UI.Xaml.Controls;
 using System;
 using System.IO;
@@ -90,8 +91,8 @@ private async ValueTask<bool> IsOutputPathSpaceSufficient(string inputPath, stri
             ArgumentException.ThrowIfNullOrEmpty(inputPath);
             ArgumentException.ThrowIfNullOrEmpty(outputPath);
 
-            DriveInfo inputDriveInfo = new DriveInfo(Path.GetPathRoot(inputPath)!);
-            DriveInfo outputDriveInfo = new DriveInfo(Path.GetPathRoot(outputPath)!);
+            string inputVolName = PathUtil.GetPathVolumeName(inputPath);
+            string outputVolName = PathUtil.GetPathVolumeName(outputPath);
 
             _totalFileSize = await Task.Run(() =>
             {
@@ -110,23 +111,24 @@ private async ValueTask<bool> IsOutputPathSpaceSufficient(string inputPath, stri
                 return returnSize;
             });
 
-            IsSameOutputDrive = inputDriveInfo.Name == outputDriveInfo.Name;
+            IsSameOutputDrive = inputVolName == outputVolName;
             if (IsSameOutputDrive)
                 return true;
 
-            bool isSpaceSufficient = outputDriveInfo.TotalFreeSpace > _totalFileSize;
+            long volumeFreeSpace = PathUtil.GetVolumeFreeSpace(outputPath);
+            bool isSpaceSufficient = volumeFreeSpace > _totalFileSize;
             if (isSpaceSufficient)
             {
                 return true;
             }
 
-            string errStr = $"Free Space on {outputDriveInfo.Name} is not sufficient! (Free space: {outputDriveInfo.TotalFreeSpace}, Req. Space: {_totalFileSize}, Drive: {outputDriveInfo.Name})";
+            string errStr = $"Free Space on {outputVolName} is not sufficient! (Free space: {volumeFreeSpace}, Req. Space: {_totalFileSize}, Drive: {outputVolName})";
             Logger.LogWriteLine(errStr, LogType.Error, true);
-            await SimpleDialogs.SpawnDialog(string.Format(Locale.Current.Lang?._Dialogs?.OperationErrorDiskSpaceInsufficientTitle ?? "", outputDriveInfo.Name),
+            await SimpleDialogs.SpawnDialog(string.Format(Locale.Current.Lang?._Dialogs?.OperationErrorDiskSpaceInsufficientTitle ?? "", outputVolName),
                                             string.Format(Locale.Current.Lang?._Dialogs?.OperationErrorDiskSpaceInsufficientMsg ?? "",
-                                                          ConverterTool.SummarizeSizeSimple(outputDriveInfo.TotalFreeSpace),
+                                                          ConverterTool.SummarizeSizeSimple(volumeFreeSpace),
                                                           ConverterTool.SummarizeSizeSimple(_totalFileSize),
-                                                          outputDriveInfo.Name),
+                                                          outputVolName),
                                             null,
                                             null,
                                             Locale.Current.Lang?._Misc?.Okay,

CollapseLauncher/Classes/GameManagement/ImageBackground/ImageBackgroundManager.Control.cs

@@ -58,7 +58,7 @@ public void Play(bool isUserRequest = true)
         bool                           hasStaticImage = !string.IsNullOrEmpty(context?.BackgroundImageStaticPath);
         if (isUserRequest && hasStaticImage && context != null)
         {
-            LoadImageAtIndex(CurrentSelectedBackgroundIndex, false, CancellationToken.None);
+            LoadImageAtIndex(CurrentSelectedBackgroundIndex, false, CancellationToken.None, true);
         }
 
         // Force to restore autoplay status to true.
@@ -81,7 +81,7 @@ public void Pause(bool isUserRequest = true)
         bool                           hasStaticImage = !string.IsNullOrEmpty(context?.BackgroundImageStaticPath);
         if (isUserRequest && hasStaticImage && context != null)
         {
-            LoadImageAtIndex(CurrentSelectedBackgroundIndex, true, CancellationToken.None);
+            LoadImageAtIndex(CurrentSelectedBackgroundIndex, true, CancellationToken.None, true);
             return;
         }