Skip to content

Make sure not to run ansible procedure in check mode#14395

Open
teacup-on-rockingchair wants to merge 1 commit intoComplianceAsCode:masterfrom
teacup-on-rockingchair:ansible_check_mode_aide_periodic_checking_systemd_timer
Open

Make sure not to run ansible procedure in check mode#14395
teacup-on-rockingchair wants to merge 1 commit intoComplianceAsCode:masterfrom
teacup-on-rockingchair:ansible_check_mode_aide_periodic_checking_systemd_timer

Conversation

@teacup-on-rockingchair
Copy link
Contributor

Description:

  • Minor patch in ansible remediation for aide_periodic_checking_systemd_timer

Rationale:

  • Make sure that ansible remediation proc in aide_periodic_checking_systemd_timer is not executed in check_mode

@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.80 milestone Feb 14, 2026
@teacup-on-rockingchair teacup-on-rockingchair added the Ansible Ansible remediation update. label Feb 14, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 14, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggbecker ggbecker modified the milestones: 0.1.80, 0.1.81 Feb 16, 2026
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the ansible_check_mode_aide_periodic_checking_systemd_timer branch from b7f7878 to 602762e Compare February 18, 2026 22:59
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review February 18, 2026 22:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 18, 2026
@jan-cerny
Copy link
Collaborator

jan-cerny commented Feb 19, 2026

@teacup-on-rockingchair Why shouldn't these tasks be run in check mode? Does it produce any problems or fails? What specific failure did you encoutner? Ansible's systemd module already supports check mode natively. When Ansible runs in check mode, the tasks would report what would change without actually making changes.

@teacup-on-rockingchair
Copy link
Contributor Author

@teacup-on-rockingchair Why shouldn't these tasks be run in check mode? Does it produce any problems or fails? What specific failure did you encoutner? Ansible's systemd module already supports check mode natively. When Ansible runs in check mode, the tasks would report what would change without actually making changes.

Yes it was raising errors

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the ansible_check_mode_aide_periodic_checking_systemd_timer branch from 1537c1c to 0a13186 Compare March 5, 2026 07:57
@Mab879 Mab879 self-assigned this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ansible Ansible remediation update.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants