Draft: Refactor PSF model optimizer handling with configurable selection and optional TensorFlow Addons #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
added 15 commits
November 13, 2025 17:22
…local utils version
… with third-party license info
…d overrides handling
jeipollack
force-pushed
the
feature/179/configurable-optimizer
branch
from
4cffe99 to
1a53193
Compare
…erformance - Add `is_optimizer_instance` helper to detect if argument is a Keras optimizer instance - Ensure get_optimizer is called once per cycle and the instance is passed to build_PSF_model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of TensorFlow Addons functions (e.g. RectifiedAdam and interpolate_spline) being incompatible with the EDEN 3.1 (TF 2.11) environment by removing TFA as a required dependency and introducing a fully configurable optimizer selection system.
Closes #179
Key changes:
optimizer.pymodule withget_optimizerfunction to centralise optimizer creation.RecursiveNamespacefrom configs,dictof hyperparameters, or"Adam"or"rectified_adam").rectified_adamis defined in the config file.tf.keras.optimizers.legacy.Adamfor TF < 2.11 and standardAdamotherwise.build_PSF_modelto accept either a Keras optimizer instance or a config passed through get_optimizer.interpolation.pyandtypes.pymodules with copied code from the TFA repotfa.image.interpolate_splinewith local equivalent renamed totfa_interpolate_spline_rbftest_optimizer.py: covers legacy/non-legacy handling, RectifiedAdam import logic, overrides, and input normalization.test_interpolation.py: basic validation for the localtfa_interpolate_spline_rbfwrapper.