Skip to content

fix(orchestrator): pass output to webhook dispatcher#341

Merged
vincentgrobler merged 1 commit intomainfrom
fix/orchestrator-webhook-output
Apr 9, 2026
Merged

fix(orchestrator): pass output to webhook dispatcher#341
vincentgrobler merged 1 commit intomainfrom
fix/orchestrator-webhook-output

Conversation

@vincentgrobler
Copy link
Copy Markdown
Collaborator

@vincentgrobler vincentgrobler commented Apr 9, 2026

Description

The orchestratorExecutor was dispatching team_run.completed webhooks without the 'output' field, causing all webhook destinations (Trello, Slack, Discord, etc.) to receive result_full: null.

  • Pass runOutput (already fetched from DB) to dispatchTeamRunWebhooks
  • Also pass team name and output_route_ids (matching pipeline executor)
  • Hoist teamData above try block so it's available in catch for errors
  • Fixes Trello creating a single empty card instead of multi-card output

Related Issue

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor (no functional changes)
  • 🧪 Test update

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Browser testing (specify browsers)

Screenshots (if applicable)

Checklist

  • My code follows the project's coding standards
  • I have run npm run lint and there are no errors
  • I have run npm run test and all tests pass
  • I have added tests for my changes (if applicable)
  • I have updated the documentation (if applicable)
  • My source files have AGPL licence headers
  • My changes generate no new TypeScript errors

The orchestratorExecutor was dispatching team_run.completed webhooks
without the 'output' field, causing all webhook destinations (Trello,
Slack, Discord, etc.) to receive result_full: null.

- Pass runOutput (already fetched from DB) to dispatchTeamRunWebhooks
- Also pass team name and output_route_ids (matching pipeline executor)
- Hoist teamData above try block so it's available in catch for errors
- Fixes Trello creating a single empty card instead of multi-card output
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crewform Ready Ready Preview, Comment Apr 9, 2026 0:00am

@vincentgrobler vincentgrobler merged commit 2b8ba27 into main Apr 9, 2026
8 checks passed
@vincentgrobler vincentgrobler deleted the fix/orchestrator-webhook-output branch April 9, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant