addons: dhcp: use ifupdown wait-for-ll6.sh method to check link-local…#331
Open
frankQAQ-wang wants to merge 1 commit intoCumulusNetworks:masterfrom
Open
addons: dhcp: use ifupdown wait-for-ll6.sh method to check link-local…#331frankQAQ-wang wants to merge 1 commit intoCumulusNetworks:masterfrom
frankQAQ-wang wants to merge 1 commit intoCumulusNetworks:masterfrom
Conversation
… address
When networking service was up, it match output used re.search('inet6 .* scope link',
addr_output), because re.search checks for a match anywhere in the string:
5: ens10: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
link/ether 52:54:00:97:3d:30 brd ff:ff:ff:ff:ff:ff
inet6 fe80::5054:ff:fe97:3d30/64 scope link tentative
valid_lft forever preferred_lft forever
It will make mistake for dhclient, because ip flag is tentative and
interface can't be bound:
error: cmd '/sbin/dhclient -6 -pf /run/dhclient6.ens10.pid -lf /var/lib/dhcp/dhclient6.ens10.leases ens10' failed: returned 1
Signed-off-by: Qiang Wang <wangqiang.wq.frank@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… address
When networking service was up, it match output used re.search('inet6 .* scope link', addr_output), because re.search checks for a match anywhere in the string:
5: ens10: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
link/ether 52:54:00:97:3d:30 brd ff:ff:ff:ff:ff:ff
inet6 fe80::5054:ff:fe97:3d30/64 scope link tentative
valid_lft forever preferred_lft forever
It will make mistake for dhclient, because ip flag is tentative and interface can't be bound:
error: cmd '/sbin/dhclient -6 -pf /run/dhclient6.ens10.pid -lf /var/lib/dhcp/dhclient6.ens10.leases ens10' failed: returned 1