Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,14 @@
"creatordate",
"crunchydata",
"customresourcedefinition",
"Datree",
"datreeio",
"editorcheck",
"elif",
"filesys",
"genall",
"gofmt",
"gomod",
"jsonschema",
"kopium",
"krusty",
Expand All @@ -34,7 +36,9 @@
"kustomizer",
"mrtazz",
"mstruebing",
"nvim",
"openpgp",
"prometheusrule",
"rollouts",
"schemafile",
"shellcheck",
Expand Down
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.PHONY: all clean test build

COMPOSE_RUN = docker compose run --rm --quiet-pull
export DOCKER_CLI_HINTS=false

DOWNLOADER := $(shell \
Expand All @@ -11,4 +10,6 @@ DOWNLOADER := $(shell \
fi \
)

include make.d/*.mk
include make.d/*.mk

all: clean help build check comparison tags test schema-check update
15 changes: 10 additions & 5 deletions configuration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@
kind: helm
name: antrea
repository: https://charts.antrea.io
- entries:
- spark-kubernetes-operator
kind: helm
name: apache-spark-kubernetes-operator
repository: https://apache.github.io/spark-kubernetes-operator
- kind: git
kustomizationPaths:
- config/crd
Expand Down Expand Up @@ -1242,6 +1247,11 @@
- ./components/pvcviewer-controller/api
- ./components/tensorboard-controller/api
versionPattern: "^v([0-9]+\\.[0-9]+\\.[0-9]+)$"
- entries:
- spark-operator
kind: helm
name: kubeflow-spark-operator
repository: https://kubeflow.github.io/spark-operator
- kind: git
kustomizationPaths:
- manifests/base/crds
Expand Down Expand Up @@ -2038,11 +2048,6 @@
kustomizationPaths:
- config/crd
repository: https://github.com/isindir/sops-secrets-operator
- entries:
- spark-operator
kind: helm
name: spark-operator
repository: https://kubeflow.github.io/spark-operator
- kind: git
name: spicedb-operator
kustomizationPaths:
Expand Down
11 changes: 0 additions & 11 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,3 @@ services:
- ./build/ephemeral/repository/http:/usr/share/nginx/html:ro
ports:
- 8088:8080
# --- test tools ---
editorconfig:
image: mstruebing/editorconfig-checker
volumes:
- .:/workspace:ro
working_dir: /workspace
checkmake:
image: mrtazz/checkmake
volumes:
- ./Makefile:/Makefile:ro
- ./make.d:/make.d:ro
2 changes: 1 addition & 1 deletion make.d/build.mk
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
GO_TAGS = containers_image_openpgp

build:
@mkdir -p build/bin
mkdir -p build/bin
go build -o build/bin/catalog -buildvcs=false -tags $(GO_TAGS)

build/bin/catalog: build
2 changes: 1 addition & 1 deletion make.d/schema-check.mk
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ schema-check: build/bin/catalog build/schemastore/jsonschema.json
find schema -type f -iname "*.json" -print0 | xargs -0 -n1 sh -ec 'build/bin/catalog verify --schema build/schemastore/jsonschema.json --file "$0"'

build/schemastore/jsonschema.json:
@mkdir -p build/schemastore
mkdir -p build/schemastore
$(DOWNLOADER) $@ https://www.schemastore.org/metaschema-draft-07-unofficial-strict.json
11 changes: 6 additions & 5 deletions make.d/tests.mk
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ test-go:
go mod tidy -diff

@echo 'Checking for incorrectly formatted files ...'
@test -z "$$(gofmt -l .)"
test -z "$$(gofmt -l .)"

ifneq ($(TOOL_VERSION),$(MOD_VERSION))
@echo 'Mismatched go versions'
Expand Down Expand Up @@ -70,7 +70,8 @@ endif

test-editorcheck:
@echo 'Checking general formatting of all files ...'
$(COMPOSE_RUN) editorconfig ec -exclude '^schema/|^\.git/|.DS_Store|^build/|^definitions/'
docker run --rm -v $(CURDIR):/workspace:ro -w /workspace mstruebing/editorconfig-checker \
ec -exclude '^schema/|^\.git/|.DS_Store|^build/|^definitions/|^schema/'
@printf $(GREEN) "OK"

test-docker:
Expand All @@ -80,13 +81,13 @@ test-docker:

test-makefile:
@echo 'Checking formatting of Makefile and *.mk files ...'
$(COMPOSE_RUN) checkmake
test -z "$$(make -n all 1>/dev/null)"
@printf $(GREEN) "OK"

build/schemastore/dependabot-2.0.json:
@mkdir -p build/schemastore
mkdir -p build/schemastore
$(DOWNLOADER) $@ https://json.schemastore.org/dependabot-2.0.json

build/schemastore/github-workflow.json:
@mkdir -p build/schemastore
mkdir -p build/schemastore
$(DOWNLOADER) $@ https://json.schemastore.org/github-workflow.json