Skip to content

Catch IllegalArgumentException in crafting process overrides to prevent crash on invalid recipes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensworks merged 2 commits into from
Feb 12, 2026
Merged

Catch IllegalArgumentException in crafting process overrides to prevent crash on invalid recipes #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e29f9f
Initial plan
Copilot Feb 12, 2026
ca480dd
Fix crash on incorrect recipe by catching IllegalArgumentException (f…
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/org/cyclops/integratedcrafting/core/CraftingJobHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,11 @@ protected boolean insertCrafting(PartPos target, IMixedIngredients ingredients,
// First check our crafting overrides
for (ICraftingProcessOverride craftingProcessOverride : this.craftingProcessOverrides) {
if (craftingProcessOverride.isApplicable(target)) {
return craftingProcessOverride.craft(targetGetter, ingredients, recipe, this.resultsSink, craftingJob, simulate);
try {
return craftingProcessOverride.craft(targetGetter, ingredients, recipe, this.resultsSink, craftingJob, simulate);
} catch (IllegalArgumentException e) {
return false;
}
}
}

Expand All @@ -576,7 +580,7 @@ protected void insertLoopNonBlocking(INetwork network, int channel, PartPos targ
IRecipeDefinition recipe = craftingJob.getRecipe();
IMixedIngredients ingredientsSimulated = CraftingHelpers.getRecipeInputsFromCraftingJobBuffer(craftingJob,
recipe, true, 1);
if (ingredientsSimulated == null ||!insertCrafting(targetPos, ingredientsSimulated, recipe, craftingJob, network, channel, true)) {
if (ingredientsSimulated == null || !insertCrafting(targetPos, ingredientsSimulated, recipe, craftingJob, network, channel, true)) {
break;
}
if (!consumeAndInsertCrafting(true, network, channel, targetPos, craftingJob)) {
Expand Down