Open
Conversation
BeckerHanne
commented
May 19, 2025
Contributor
Author
BeckerHanne
left a comment
BeckerHanne
left a comment
There was a problem hiding this comment.
Hi @johentsch , I left a couple of comments in the code here for discussion. Thanks!!
| 8 8 22 22 1.5 1/4 1/4 Chord 3/4 1 1 3/8 1/4 3/2 40 | ||
| 8 8 47/2 47/2 0.5 5/8 5/8 Chord 3/4 1 1 1/8 1/8 1 41 | ||
| 8 8 21 21 1.0 0 0 Chord 3/4 2 1 1/4 1/4 1 42 | ||
| 8 8 22 22 1.5 1/4 1/4 Chord 3/4 2 1 3/8 1/4 3/2 43 ornamentPrecompMordentUpperPrefix |
Contributor
Author
There was a problem hiding this comment.
@johentsch After checking this now I see this. Adding ornaments adds a super long string into the chords.tsv ....should we refrain from adding ornaments? (Sorry, there are so many places rn to look for the procedures, I might be missing some. 😊 )
| "@id": "https://orcid.org/0000-0002-1986-9545" | ||
| }, | ||
| "softwareVersion": "2.5.4" | ||
| "softwareVersion": "0.0.post1.dev1+g6d954be" |
Contributor
Author
There was a problem hiding this comment.
Hmmm not sure why this version of ms3 shows up here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://op-musicology.epfl.ch/projects/corpus-building/work_packages/1477/
This contains the first opening measures of Sonata XII (also known as Ciacona in an earlier source). I wasn't sure which measure of consistency we wanted to apply, since this is a type of outlier in the sense that the Ciacona Largo immediately segue ways into an Allegro in bar 17. Therefore if we were to encode the Allegro as a separate movement, there would be technically a duplication of measure 17, which in effect becomes m.1 of the new movement.
My instinct would be to encode the entire Sonata as just one file. Please let me know what you would like.
If we decide that this is indeed one long movement, and not two, I hope the file as is can be extended with adding bars and notes; if not, then perhaps we should close this PR and start from scratch to accommodate the (long) last piece. If we decide on one long piece, how will we name it 1) op02n12a or 2)op02n12?
I let all bass figures be at the default, and did not manually lengthen any.
Thank you, @johentsch