Skip to content

fix: SUI-1973 - support existing storage resources#357

Merged
IgiCodes merged 5 commits into
mainfrom
feat/SUI-1973-existing-blob-resources
Jun 11, 2026
Merged

fix: SUI-1973 - support existing storage resources#357
IgiCodes merged 5 commits into
mainfrom
feat/SUI-1973-existing-blob-resources

Conversation

@IgiCodes

@IgiCodes IgiCodes commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds safer support for the blob-event-processor stack when using a pre-existing storage account, while reducing expected what-if noise from Azure-managed defaults and DfE policy tags.

Changes

  • Treat storage account blobServices/default and queueServices/default as existing service handles, so the stack only manages the SUI-owned containers, queues, private endpoints, DNS, and Event Grid wiring.
  • Preserve default blob container properties explicitly to avoid repeated container drift in what-if output.
  • Add optional tag controls for policy-shaped environments:
    • tagEnvironmentName lets deployments align the Environment tag with policy expectations.
    • additionalTags / AZURE_ADDITIONAL_TAGS lets DfE-specific tags such as Service Offering be supplied from repo variables instead of being hard-coded into client infrastructure.
  • Pass the shared stack tags into Key Vault without replacing its required Aspire tag.
  • Document existing-storage behaviour and the optional tag configuration for GitHub Actions and direct deployments.

Validation

  • Built infra/stacks/blob-event-processor/main.bicep with az bicep build.
  • Built infra/stacks/blob-event-processor/subscription.bicep with az bicep build.
  • Ran create-mode what-if from the branch and confirmed the storage account, containers, queues, private endpoints, and Event Grid resources are no-change.

@IgiCodes IgiCodes changed the title fix: SUI-1973 - avoid managing storage service defaults fix: SUI-1973 - support existing storage resources Jun 10, 2026
@IgiCodes IgiCodes marked this pull request as ready for review June 10, 2026 15:40
@IgiCodes IgiCodes requested a review from a team as a code owner June 10, 2026 15:40
@IgiCodes IgiCodes enabled auto-merge (rebase) June 10, 2026 15:42
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
suiw 100% 100%
SUI.Client.Core 94% 91%
Matching 74% 49%
External 45% 32%
Shared 92% 84%
AppHost 100% 100%
SUI.Client.StorageProcessJob 97% 80%
SUI.DBS.Response.Logger.Core 94% 76%
Summary 80% (3816 / 4773) 63% (1001 / 1600)

Comment thread infra/modules/blob-event-processor/storage-resources.bicep
@IgiCodes IgiCodes merged commit 35c291e into main Jun 11, 2026
5 checks passed
@IgiCodes IgiCodes deleted the feat/SUI-1973-existing-blob-resources branch June 11, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants