[8.0] JobAgent - do not fail already rescheduled job #8427
+27
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsareg
added
the
alsoTargeting:integration
atsareg
changed the title
fstagni
reviewed
Jan 22, 2026
| job.sendJobAccounting(status=JobStatus.FAILED, minorStatus=JobMinorStatus.UPLOADING_JOB_OUTPUTS) | ||
|
|
||
| return 2 | ||
| return JW.FINALIZATION_FAILED |
Contributor
There was a problem hiding this comment.
Return value 2 is now "PAYLOAD_FAILED" but here you are returning 3 for "FINALIZATION_FAILED". I do not know if this is on purpose.
| job.sendFailoverRequest() | ||
| job.sendJobAccounting(status=JobStatus.FAILED, minorStatus=JobMinorStatus.UPLOADING_JOB_OUTPUTS) | ||
| return 2 | ||
| return JW.FINALIZATION_FAILED |
| # In order to avoid overriding perfectly valid states, the status is updated iff the job was running | ||
| # The payload failed (if result["Value"] is not 0 and the job was not rescheduled) | ||
| elif result["Value"] and result["Value"] != RESCHEDULED: | ||
| # In order to avoid overriding perfectly valid states, the status is updated if the job was running |
Contributor
There was a problem hiding this comment.
I think the original "iff" was there for "if and only if".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs that failed initialization, e.g. input sandbox download, are rescheduled by the jobwrapper and return non-zero status. JobAgent checks the job status with a certain delay, can be few minutes in the case of Pool/Singularity inner CE. The job can be already rescheduled, matched and running on another site again by this time. JobAgent sets the job status to Failed if it is in a Running status even if it is running after a successful rescheduling elsewhere. This Failed status is false in this case and should not be set.
BEGINRELEASENOTES
*WorkloadManagement
FIX: JobAgent - do not fail already rescheduled job
ENDRELEASENOTES