ci-runners: audit query must match all Actions SKUs, not just Linux - #126
Open
DJRHails wants to merge 1 commit into
Open
ci-runners: audit query must match all Actions SKUs, not just Linux#126DJRHails wants to merge 1 commit into
DJRHails wants to merge 1 commit into
Conversation
The billing audit snippet added in #125 filtered sku=="Actions Linux" exactly, silently dropping macOS (10x rate), Windows, and larger-runner SKUs — the same silent-scoping failure the section warns about. Prefix match on "Actions" instead; storage rows ride along at pennies, erring toward over-reporting. Resolves the P2 finding from the post-merge review of #125.
Owner
Author
Review SummaryDirect single-pass review (7-line docs-only diff, one README). No P1–P3 findings — the change is correct and does exactly what it claims. FindingsNone. Two things considered and dismissed (informational):
Verification
CommitNo fix commit needed — nothing to change. Verdict: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the post-merge review of #125 (finding F1).
The billing audit snippet filtered
sku=="Actions Linux"exactly, whichsilently drops every other billed Actions SKU —
Actions macOS(10× theLinux rate),
Actions Windows, and larger runners (Actions Linux 4-core).That re-introduces the failure class the section exists to warn about: a
scoping choice that under-reports spend with no visible sign. Verified
against a mock payload — a macOS repo at $0.80 and a 4-core repo at $0.40
were both invisible to the exact-match query.
Now a prefix match on
Actions, with a README line explaining why. Storagerows ride along at pennies, which errs toward over-reporting — the right
direction for an audit.
via gantry