Skip to content

skills(sage-saint): correct gotchas after repair pass - #134

Merged
DJRHails merged 1 commit into
mainfrom
sage-saint-skill-corrections
Aug 24, 2026
Merged

skills(sage-saint): correct gotchas after repair pass#134
DJRHails merged 1 commit into
mainfrom
sage-saint-skill-corrections

Conversation

@DJRHails

Copy link
Copy Markdown
Owner

Retracts a false CLI gotcha (it was output truncation, not a bug), records the now-fixed release-pipeline failures, and adds a colima /tmp bind-mount trap. Details inside the encrypted file.

via claude @ trifle

@DJRHails
DJRHails merged commit bc97b7f into main Aug 24, 2026
@DJRHails
DJRHails deleted the sage-saint-skill-corrections branch August 24, 2026 10:12
@DJRHails

Copy link
Copy Markdown
Owner Author

Review Summary

Post-merge review (the PR merged at 10:12 UTC, before this review ran). Direct single-pass review — one encrypted docs file, no code. The diff on GitHub is ciphertext, so findings are described generically here and inline comments were not posted; fixes went to a fresh branch off main instead of this (merged) branch.

What was reviewed

  • Decrypted and diffed both revisions of the changed file with the fleet key; read the full updated document for internal consistency with the new sections.
  • Envelope integrity: recipient set unchanged and matches .sops.yaml's default rule, MAC + lastmodified updated, committed blob is ciphertext. ✅
  • Cross-checked the "now-fixed release-pipeline failures" claim against the release repo's workflow history — the fix commits (2026-08-24) exist and match what the gotcha records. ✅

Findings

# Severity Finding Resolution
1 P3 Comment rot: an untouched runbook step still describes a release-pipeline failure as expected/cosmetic that this PR's own gotcha records as fixed — post-fix, that advice would mask a real regression. Fixed in follow-up #135
2 P4 A stack-map row names only one of the two container-naming vintages this PR documents. Fixed in follow-up #135 (trivial)

The corrections themselves (the retracted CLI gotcha, the release-pipeline update, the new trap sections) are accurate, internally consistent, and well-provenanced.

Verification

  • Hooks: full pre-commit suite passed on the fix commit (secret scans, glassine checks, all four behaviour suites)
  • Secrets: gitleaks (staged) + trufflehog (plaintext tree) clean
  • Envelope: ciphertext round-trip verified

Commit

5cdb2d788816 on #135 — skills(sage-saint): align runbook prose with corrected gotchas

Verdict: approve

via gantry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant