linode: Modernize record conversion#4560
Open
TomOnTime wants to merge 8 commits into
Open
Conversation
Collaborator
Author
|
Dear @koesie10, GitHub could not add you as a reviewer, so I sent you an invitation for triage access to this repository. Please accept the invitation when convenient, then take a look at this PR and run the provider integration test. Thank you! |
TomOnTime
marked this pull request as ready for review
July 24, 2026 01:37
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
@TomOnTime Sorry for the late response. To make the integration tests run, I've had to make one change: diff --git a/providers/linode/linodeProvider.go b/providers/linode/linodeProvider.go
index f474864c..99de1ddf 100644
--- a/providers/linode/linodeProvider.go
+++ b/providers/linode/linodeProvider.go
@@ -216,6 +216,7 @@ func (api *linodeProvider) GetZoneRecordsCorrections(dc *models.DomainConfig, ex
case diff2.CHANGE:
id := change.Old[0].Original.(*domainRecord).ID
if id == 0 { // Skip ID 0, these are the default nameservers always present
+ actualChangeCount--
continue
}
req, err := toReq(dc, change.New[0])After that change, these are the failing tests: This was run using |
Collaborator
Author
|
Interesting! They all seem to be having the same issue: "Expected 0 corrections on second run, but found 2." means that the correction was send/requested, but when it read things back there were still corrections to make, which mean the change request was malformed in some way. The fact that what its deleting (to correct the wrong change) is a label Line 313-ish: Hope that helps! |
Collaborator
Author
|
koesie10: I don't have a way to contact you in case there is a problem with Github. Could you please email me at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @koesie10. I could use your help. I'm doing upgrades to the code base and I have no way to test your provider. Please run the integration test and let me know the result. How to run integration tests is here: https://docs.dnscontrol.org/developer-info/integration-tests
Summary
Validation
../../bin/is_modern.sh(Steps 1-7 clean)go test ./providers/linodebin/generate-all.shgo test ./...