openwrt: Modernize record conversion - #4571
Merged
Merged
Conversation
huskyistaken
approved these changes
Jul 22, 2026
Collaborator
There was a problem hiding this comment.
Changes look good to me, the integration tests still pass.
Here's the test logs:
4571.log
TomOnTime
marked this pull request as ready for review
July 23, 2026 01:17
Collaborator
Author
|
Thanks for running the tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @huskyistaken. I could use your help. I'm doing upgrades to the code base and I have no way to test your provider. Please run the integration test and let me know the result. How to run integration tests is here: https://docs.dnscontrol.org/developer-info/integration-tests
Summary
Validation
../../bin/is_modern.sh(Steps 1-7 clean)go test ./providers/openwrtbin/generate-all.shgo test ./...