Skip to content

realtimeregister: Modernize record conversion - #4575

Merged
TomOnTime merged 3 commits into
release_candidate_v5from
mod_realtimeregister
Jul 23, 2026
Merged

realtimeregister: Modernize record conversion#4575
TomOnTime merged 3 commits into
release_candidate_v5from
mod_realtimeregister

Conversation

@TomOnTime

Copy link
Copy Markdown
Collaborator

Dear @PJEilers. I could use your help. I'm doing upgrades to the code base and I have no way to test your provider. Please run the integration test and let me know the result. How to run integration tests is here: https://docs.dnscontrol.org/developer-info/integration-tests

Summary

  • build downloaded records with modern record factories
  • remove legacy DNS name expansion and type-specific setters
  • serialize multi-field records from modern RDATA

Validation

  • ../../bin/is_modern.sh (Steps 1-7 clean)
  • go test ./providers/realtimeregister
  • bin/generate-all.sh
  • go test ./...

@PJEilers

Copy link
Copy Markdown
Contributor

Will take a look at it today

@PJEilers

Copy link
Copy Markdown
Contributor

integration_test_rtr.txt

These are the results of the integration tests. One test is failing:

--- FAIL: TestDNSProviders/test-abcdefghi-123.com/26:NS_only_APEX:Single_NS_at_apex (0.34s)

This test can be disabled however as this operation is not allowed at RTR: Cannot be a SOA level record for type NS

@PJEilers PJEilers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see prev comment

@TomOnTime

Copy link
Copy Markdown
Collaborator Author

integration_test_rtr.txt

These are the results of the integration tests. One test is failing:

--- FAIL: TestDNSProviders/test-abcdefghi-123.com/26:NS_only_APEX:Single_NS_at_apex (0.34s)

This test can be disabled however as this operation is not allowed at RTR: Cannot be a SOA level record for type NS

Thanks! i've disabled it.

diff --git a/integrationTest/integration_test.go b/integrationTest/integration_test.go
index 52c49022..05a4a502 100644
--- a/integrationTest/integration_test.go
+++ b/integrationTest/integration_test.go
@@ -489,6 +489,7 @@ func makeTests() []*TestGroup {
                                "NAMEDOTCOM",        // "Ignores @ for NS records"
                                "NETCUP",            // NS records not currently supported.
                                "PORKBUN",           // Record ignored.
+                               "REALTIMEREGISTER",  // "Cannot be a SOA level record for type NS"
                                "SAKURACLOUD",       // Silently ignores requests to remove NS at @.
                                "TRANSIP",           // "it is not allowed to have an NS for an @ record"
                                "VERCEL",            // "invalid_name - Cannot set NS records at the root level. Only subdomain NS records are supported"

@TomOnTime
TomOnTime marked this pull request as ready for review July 23, 2026 14:00
@TomOnTime
TomOnTime merged commit 9a2e03b into release_candidate_v5 Jul 23, 2026
24 checks passed
@TomOnTime
TomOnTime deleted the mod_realtimeregister branch July 23, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants