Skip to content

Comments

Upgrade vcpkg#241

Merged
jwillemsen merged 2 commits intoDOCGroup:masterfrom
jwillemsen:jwi-vcpkg2
Feb 20, 2026
Merged

Upgrade vcpkg#241
jwillemsen merged 2 commits intoDOCGroup:masterfrom
jwillemsen:jwi-vcpkg2

Conversation

@jwillemsen
Copy link
Member

@jwillemsen jwillemsen commented Feb 20, 2026

* .github/workflows/windows.yml:

Summary by CodeRabbit

  • Chores
    • Updated build infrastructure dependencies.

    * .github/workflows/windows.yml:
@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

Walkthrough

A GitHub Actions workflow configuration update in the Windows CI pipeline that changes the vcpkg installation to use a different Git commit, replacing the previous commit hash with a newer one for the build environment.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/windows.yml
Updated vcpkg Git commit ID in the "Install vcpkg" step from c82f74667287d3dc386bce81e44964370c91a289 to 66c0373dc7fca549e5803087b9487edfe3aca0a1 to use a newer vcpkg version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, a commit so new,
The vcpkg version gets its due,
With just one hash to swap about,
Our Windows builds shall work throughout! 🏗️

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade vcpkg' directly and clearly summarizes the main change—updating the vcpkg commit hash in the Windows workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/windows.yml (1)

78-80: ⚠️ Potential issue | 🟠 Major

Pre-existing: out-file on Line 79 overwrites the file written on Line 78.

Line 79 is missing -append, so the xerces3=1 entry silently replaces the ipv6=1 entry. This is pre-existing and outside the changed segment, but the CI build will silently omit the ipv6 feature.

🐛 Proposed fix
-        echo "xerces3=1" | out-file -encoding ASCII ${env:ACE_ROOT}/bin/MakeProjectCreator/config/default.features
+        echo "xerces3=1" | out-file -append -encoding ASCII ${env:ACE_ROOT}/bin/MakeProjectCreator/config/default.features
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/windows.yml around lines 78 - 80, The second out-file call
overwrites the file created by the first out-file, so add the -append flag to
the middle command that writes "xerces3=1" (the out-file invocation targeting
${env:ACE_ROOT}/bin/MakeProjectCreator/config/default.features) so it appends
rather than replaces the existing "ipv6=1" entry; ensure all three echo/out-file
lines consistently use -append (or the first creates the file and the others
append) to preserve all feature entries in default.features.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/windows.yml:
- Around line 78-80: The second out-file call overwrites the file created by the
first out-file, so add the -append flag to the middle command that writes
"xerces3=1" (the out-file invocation targeting
${env:ACE_ROOT}/bin/MakeProjectCreator/config/default.features) so it appends
rather than replaces the existing "ipv6=1" entry; ensure all three echo/out-file
lines consistently use -append (or the first creates the file and the others
append) to preserve all feature entries in default.features.

    * .github/workflows/windows.yml:
@jwillemsen jwillemsen merged commit 58a6fbe into DOCGroup:master Feb 20, 2026
10 checks passed
@jwillemsen jwillemsen deleted the jwi-vcpkg2 branch February 20, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant