ORCID iDs should be displayed according to ORCID's Display Guidelines

[Sondissimo]

References

Add references/links to any related issues or PRs.

• Fixes ORCID iDs should be displayed according to ORCID's Display Guidelines #4656
• Required Rest PR: Exposed ORCID domain-url to help fix ORCID display DSpace#11432

Description

Implemented clickable orcid icon and uuid in person item page that redirects to the orcid website person profile
Now the little orcid icon next to the person in item view redirects to orcid website person profile

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
Test with the rest counterpart: DSpace/DSpace#11432

List of changes in this PR:
Created new component to show uuid with orcid icon in the person page if it has orcid, with redirect to the orcid website and lands on the person page

updated icon in the related items where the author has orcid and now it redirects to the orcid website and lands on the author page

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Test the pr with the rest counterpart, to test firstly go to the page of a person that has orcid, check if the orcid uuid with the icon redirects you to the orcid website on the person page
Then go on an item where the author has orcid and when the little orcid icon next to the person is shown click it and expect it to redirect onto the orcid website on the author page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the https://github.com/DSpace/DSpace/pull/11432checklist, don't hesitate to ask. We're here to help!

• [x ] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• [x ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• [x ] My PR passes ESLint validation using npm run lint
• [x ] My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• [x ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• [x ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• [x ] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• [x ] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• [x ] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• [x ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• [x ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• [x ] If my PR fixes an issue ticket, I've linked them together.

[nwoodward]

Thanks @Sondissimo! I tested this PR, as well as the backend PR (DSpace/DSpace#11432), and together they work really well. I now see the clickable ORCiD icon on the person and publication pages.

I have one question about the ORCiD link on the person page. The entire red box is clickable for me, but it would be better if only the person's name and the ORCiD icon were clickable. Can you make that change?

[github-actions]

Hi @Sondissimo,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[jrcwiok]

Tested with DSpace/DSpace#11432 and works great

[tdonohue]

@Sondissimo : If you can find time to rebase this on main (to resolve the merge conflict) and respond to @nwoodward 's feedback in his review, I think this is very close to ready to merge.

[tdonohue]

@Sondissimo : Just another reminder that this PR is waiting on updates.

[tdonohue]

@Sondissimo or @atarix83 : This PR (and the backend PR) has been stalled for months waiting for updates (see reviews above from Nov and Dec). Could we find time to get this updated so that it can be re-tested & possibly merged?

[nwoodward]

For what it's worth, encapsulating the <a> tag with a <span> tag containing the same classes from the link in src/app/item-page/simple/field-components/specific-field/orcid/item-page-orcid-field.component.html ensures that only the ORCiD logo and ID are clickable.

@if (hasOrcidMetadata) {
  <div class="item-page-field mb-2">
    <label class="font-weight-bold">{{ label | translate }}</label>
    <span class="d-flex align-items-center">
      <a [href]="orcidUrl$ | async" target="_blank" rel="noopener noreferrer">
        <img [src]="img.URI" [alt]="img.alt | translate" class="orcid-icon" />
        <span>{{ orcidId }}</span>
      </a>
    </span>
  </div>
}

[nwoodward]

Since the 10.0 deadline is fast approaching, and this PR is important for ORCID certification, I would be okay with fixing the merge conflicts and getting it into the codebase. I can always create a follow-up PR to make only the text and icon clickable. Once the merge conflicts are resolved, I'll give it a quick test again and be +1.

[tdonohue]

@nwoodward : If you are willing to fix the merge conflicts here (either in this PR or in a new PR), I'd welcome it. However, to be clear, this qualifies as a "bug fix", so it's able to be merged later in the 10.0 release process. Nonetheless, I'd also welcome merging it soon if we can get the merge conflicts cleaned up :)

[lgeggleston]

Closing this to avoid duplicates since @nwoodward opened a new PR fixing the merge conflicts to move this forward; but of course let me know if we need to reverse that. Thanks!