Conversation
The SoC code requires or GPE DW config values to be different. Assign the default values of PMC GPIO_CONF register as GPIO GPEs are not used on this platform. Fixes the assertion in soc/intel/elkhartalke/pmutil. TEST=Boot Protectli VP2420 to Ubuntu 24.04. Upstream-Status: https://review.coreboot.org/c/coreboot/+/87049 Change-Id: Ibf4a1f52bf970c27d0ca8dd1b1377d6a5e6477f9 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Based on the description of PMC GPIO_CONF register from EHL EDS Vol 2 Book 2 rev 2.3 R&DC #614109. Some of the groups had incorrect values or even defined non-existent GPIO groups. TEST=Boot Protectli VP2420 to Ubuntu 24.04. Upstream-Status: https://review.coreboot.org/c/coreboot/+/87050 Change-Id: I910f3c4c0d31b8d24b83cd2c3a28688b898b5d9f Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
The board uses GPP_G19 as GPIO interrupt for SPI dTPM. The pad is already configured as APIC interrupt, so simply define the TPM_PIRQ to GPP_G19_IRQ, which is 0x6B for Elkhart Lake. TEST=Boot Ubuntu 24.04 and check dmesg that Linux does not complain on TPM interrupt not working. Check Windows Device Manager does not report any problem with TPM and its resources. Upstream-Status: https://review.coreboot.org/c/coreboot/+/87051 Change-Id: Ia23319680cff927f10b44d7a5d07928cc30dbc9d Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Modern TPMs do not use legacy I/O access in favor of MMIO access. Discard the I/O resource, so it is not added to the ACPI _CRS. TEST=Boot Ubuntu 24.04 and check dmesg that Linux does not report problems with TPM. Check Windows Device Manager does not report any problem with TPM and its resources. Upstream-Status: https://review.coreboot.org/c/coreboot/+/87052 Change-Id: I0e504af6bc7268bc5ecce2e6642ed172ab682726 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Contributor
Author
|
The branch name is a bit awkward, because I though about configuring this GPIO pin as SCI. But now that I don't see the error anymore, I don't see any reason to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix Dasharo/dasharo-issues#1013 one error by one.
For now I haven't noticed the TPM interrupt not working error in dmesg on Ubuntu 24.04 so looks promising. I will apply the same changes for other platforms with SPI TPM if where necessary.