Open
Conversation
Contributor
Author
|
Hmm the tests on QEMU won't pass. The presence of Sovereign Boto changes the boot flow. THe wizard always coms first, prompt is not printed in this case. |
Contributor
|
I am glad that we have added this check, and are aware of this prior merging, not after. Sounds like we need to adjust the tests first prior merging this? |
Contributor
Author
I don't think any test adjustment will work here. The boot flow looks much different than usual. I think the best would be to have a separate QEMU config with the wizard enabled, because when the wizard is enabled, only the tests from the new suite will work |
Upstream-Status: Inappropriate [custom EDK2 application] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
miczyg1
force-pushed
the
sv_boot_integration
branch
from
0a99a35 to
4718ca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.