dts-subscription: error out if no password is provided#125
Open
xyhhx wants to merge 2 commits intoDasharo:mainfrom
Open
dts-subscription: error out if no password is provided#125xyhhx wants to merge 2 commits intoDasharo:mainfrom
xyhhx wants to merge 2 commits intoDasharo:mainfrom
Conversation
resolves: Dasharo/dasharo-issues#1326 Signed-off-by: xyhhx <xyhhx@tuta.io>
m-iwanicki
requested changes
Nov 24, 2025
| echo "" | ||
| read -p "Enter password: " 'DPP_PASSWORD' | ||
|
|
||
| if [[ -z "${DPP_PASSWORD}" ]]; then |
Contributor
There was a problem hiding this comment.
The same problem happens when e-mail is empty, I forgot to mention it in issue.
Add another, separate check for e-mail just after entering it. That way E2E007.005 Check empty e-mail should not pass and E2E007.006 Check empty password should not pass should both pass
Contributor
There was a problem hiding this comment.
I see you added 98ad37f, please move check between e-mail and password input:
read -p "Enter DPP email: " 'DPP_EMAIL'
echo ""
if [[ -z "${DPP_EMAIL}" ]]; then
print_error "No email address was provided."
return 1
fi
read -p "Enter password: " 'DPP_PASSWORD'Signed-off-by: xyhhx <xyhhx@tuta.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: Dasharo/dasharo-issues#1326