-
Notifications
You must be signed in to change notification settings - Fork 168
⚗️ [RUM-13259] Add shadow DOM support for action selectors #4097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccb1ca4218
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 72be44c | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BeltranBulbarellaDD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Works perfectly with the html test
Looks good in the explorer UI too
sethfowler-datadog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit 72be44cef8 will soon be integrated into staging-05.
Commit 72be44cef8 has been merged into staging-05 in merge commit 0debb8f7a3. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Integrated commit sha: 72be44c Co-authored-by: rgaignault <roman.gaignault@datadoghq.com>
Motivation
Second part of shadow DOM support for actions. This PR adds selector generation for elements inside shadow DOM, using a
/shadow/marker to indicate shadow boundaries.Follows up on the first PR that added action name support.
Changes
These two pictures are coming from the same click with and without the parameter enabled. The selector is correct and more precise that's why the width and height are smaller.
Before
After
Selector query
Test instructions
Checklist