Skip to content

RUM Rename feature to journey strong link to link in comments and desc #4992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
api-clients-generation-pipeline wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RUM Rename feature to journey strong link to link in comments and desc #4992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 63 additions & 61 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions examples/v2/rum-operations/CreateRUMOperationStrongLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Create a RUM operation strong link returns "Created" response
* Create a RUM operation link returns "Created" response
*/

import { client, v2 } from "@datadog/datadog-api-client";
Expand All @@ -13,7 +13,7 @@ const params: v2.RUMOperationsApiCreateRUMOperationStrongLinkRequest = {
data: {
attributes: {
description: undefined,
featureId: "feature-123",
featureId: "journey-123",
operationId: "abc12345-1234-5678-abcd-ef1234567890",
status: "CONFIRMED",
tags: [],
Expand Down
2 changes: 1 addition & 1 deletion examples/v2/rum-operations/DeleteRUMOperationStrongLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Delete a RUM operation strong link returns "No Content" response
* Delete a RUM operation link returns "No Content" response
*/

import { client, v2 } from "@datadog/datadog-api-client";
Expand Down
2 changes: 1 addition & 1 deletion examples/v2/rum-operations/ListRUMOperationStrongLinks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* List RUM operation strong links returns "OK" response
* List RUM operation links returns "OK" response
*/

import { client, v2 } from "@datadog/datadog-api-client";
Expand Down
2 changes: 1 addition & 1 deletion examples/v2/rum-operations/UpdateRUMOperationStrongLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Update a RUM operation strong link returns "OK" response
* Update a RUM operation link returns "OK" response
*/

import { client, v2 } from "@datadog/datadog-api-client";
Expand Down
154 changes: 77 additions & 77 deletions features/v2/rum_operations.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Feature: RUM Operations
Manage [RUM Operations](https://docs.datadoghq.com/real_user_monitoring/),
business transactions detected from RUM events through a configurable
journey, and their strong links to features. See the [RUM & Session Replay
journey, and their links to journeys. See the [RUM & Session Replay
page](https://docs.datadoghq.com/real_user_monitoring/) for more
information.

Expand All @@ -11,6 +11,38 @@ Feature: RUM Operations
And a valid "appKeyAuth" key in the system
And an instance of "RUMOperations" API

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation link returns "Bad Request" response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "journey-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation link returns "Conflict. A link between this operation and journey already exists." response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "journey-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
When the request is sent
Then the response status is 409 Conflict. A link between this operation and journey already exists.

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation link returns "Created" response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "journey-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
When the request is sent
Then the response status is 201 Created

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation link returns "Not Found. The referenced `operation_id` does not exist." response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "journey-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
When the request is sent
Then the response status is 404 Not Found. The referenced `operation_id` does not exist.

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation returns "Bad Request" response
Given operation "CreateRUMOperation" enabled
Expand All @@ -36,36 +68,22 @@ Feature: RUM Operations
Then the response status is 200 OK

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation strong link returns "Bad Request" response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "feature-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation strong link returns "Conflict. A strong link between this operation and feature already exists." response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "feature-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
When the request is sent
Then the response status is 409 Conflict. A strong link between this operation and feature already exists.

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation strong link returns "Created" response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "feature-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
Scenario: Delete a RUM operation link returns "No Content" response
Given operation "DeleteRUMOperationStrongLink" enabled
And new "DeleteRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 201 Created
Then the response status is 204 No Content

@generated @skip @team:DataDog/rum-backend
Scenario: Create a RUM operation strong link returns "Not Found. The referenced `operation_id` does not exist." response
Given operation "CreateRUMOperationStrongLink" enabled
And new "CreateRUMOperationStrongLink" request
And body with value {"data": {"attributes": {"description": null, "feature_id": "feature-123", "operation_id": "abc12345-1234-5678-abcd-ef1234567890", "status": "CONFIRMED", "tags": []}, "type": "strong_links"}}
Scenario: Delete a RUM operation link returns "Not Found" response
Given operation "DeleteRUMOperationStrongLink" enabled
And new "DeleteRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 404 Not Found. The referenced `operation_id` does not exist.
Then the response status is 404 Not Found

@generated @skip @team:DataDog/rum-backend
Scenario: Delete a RUM operation returns "No Content" response
Expand All @@ -83,24 +101,6 @@ Feature: RUM Operations
When the request is sent
Then the response status is 404 Not Found

@generated @skip @team:DataDog/rum-backend
Scenario: Delete a RUM operation strong link returns "No Content" response
Given operation "DeleteRUMOperationStrongLink" enabled
And new "DeleteRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 204 No Content

@generated @skip @team:DataDog/rum-backend
Scenario: Delete a RUM operation strong link returns "Not Found" response
Given operation "DeleteRUMOperationStrongLink" enabled
And new "DeleteRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 404 Not Found

@generated @skip @team:DataDog/rum-backend
Scenario: Get a RUM operation by name returns "Bad Request" response
Given operation "GetRUMOperationByName" enabled
Expand Down Expand Up @@ -142,13 +142,13 @@ Feature: RUM Operations
Then the response status is 200 OK

@generated @skip @team:DataDog/rum-backend
Scenario: List RUM operation strong links returns "Bad Request" response
Scenario: List RUM operation links returns "Bad Request" response
Given new "ListRUMOperationStrongLinks" request
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/rum-backend
Scenario: List RUM operation strong links returns "OK" response
Scenario: List RUM operation links returns "OK" response
Given new "ListRUMOperationStrongLinks" request
When the request is sent
Then the response status is 200 OK
Expand All @@ -167,6 +167,36 @@ Feature: RUM Operations
When the request is sent
Then the response status is 200 OK

@generated @skip @team:DataDog/rum-backend
Scenario: Update a RUM operation link returns "Bad Request" response
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/rum-backend
Scenario: Update a RUM operation link returns "Not Found" response
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 404 Not Found

@generated @skip @team:DataDog/rum-backend
Scenario: Update a RUM operation link returns "OK" response
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 200 OK

@generated @skip @team:DataDog/rum-backend
Scenario: Update a RUM operation returns "Bad Request" response
Given operation "UpdateRUMOperation" enabled
Expand Down Expand Up @@ -202,33 +232,3 @@ Feature: RUM Operations
And body with value {"data": {"attributes": {"application_id": "abc12345-1234-5678-abcd-ef1234567890", "category": null, "description": null, "display_name": "Checkout completed", "feature_ids": [], "journey_rum": {"rum_steps": [{"composite": {"kind": "all_of", "max_window_ms": 30000, "predicates": [{"query": "@type:action @action.type:click"}]}, "nodes": [{"query": "@type:action @action.type:click"}], "type": "start"}]}, "name": "checkout_completed", "tags": ["team:checkout"]}, "id": "abc12345-1234-5678-abcd-ef1234567890", "type": "operations"}}
When the request is sent
Then the response status is 200 OK

@generated @skip @team:DataDog/rum-backend
Scenario: Update a RUM operation strong link returns "Bad Request" response
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/rum-backend
Scenario: Update a RUM operation strong link returns "Not Found" response
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 404 Not Found

@generated @skip @team:DataDog/rum-backend
Scenario: Update a RUM operation strong link returns "OK" response
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 200 OK
23 changes: 12 additions & 11 deletions packages/datadog-api-client-v2/apis/RUMOperationsApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,7 +1441,7 @@ export interface RUMOperationsApiDeleteRUMOperationStrongLinkRequest {
*/
rumOperationId: string;
/**
* The unique identifier of the feature.
* The unique identifier of the journey.
* @type string
*/
featureId: string;
Expand Down Expand Up @@ -1490,7 +1490,7 @@ export interface RUMOperationsApiListRUMOperationsRequest {
*/
team?: string;
/**
* Filter operations by feature ID. Accepts a comma-separated list of feature IDs.
* Filter operations by journey ID. Accepts a comma-separated list of journey IDs.
* @type string
*/
featureId?: string;
Expand All @@ -1503,12 +1503,12 @@ export interface RUMOperationsApiListRUMOperationsRequest {

export interface RUMOperationsApiListRUMOperationStrongLinksRequest {
/**
* Filter strong links by RUM operation ID.
* Filter links by RUM operation ID.
* @type string
*/
operationId?: string;
/**
* Filter strong links by feature ID.
* Filter links by journey (feature) ID.
* @type string
*/
featureId?: string;
Expand Down Expand Up @@ -1543,7 +1543,7 @@ export interface RUMOperationsApiUpdateRUMOperationStrongLinkRequest {
*/
rumOperationId: string;
/**
* The unique identifier of the feature.
* The unique identifier of the journey.
* @type string
*/
featureId: string;
Expand Down Expand Up @@ -1592,7 +1592,7 @@ export class RUMOperationsApi {
}

/**
* Create a strong link between a RUM operation and a feature, confirming that the feature
* Create a link between a RUM operation and a journey, confirming that the journey
* belongs to the operation. The operation can be identified by `operation_id` or `operation_name`;
* if `operation_name` does not match an existing operation, a stub operation is created.
* @param param The request object
Expand Down Expand Up @@ -1636,7 +1636,7 @@ export class RUMOperationsApi {
}

/**
* Delete the strong link between a RUM operation and a feature.
* Delete the link between a RUM operation and a journey.
* @param param The request object
*/
public deleteRUMOperationStrongLink(
Expand Down Expand Up @@ -1703,7 +1703,8 @@ export class RUMOperationsApi {
}

/**
* Search RUM operations for your organization. Supports filtering by query, creator, team, feature, and application.
* Search RUM operations for your organization. Supports filtering by query, creator, team,
* journey, and application.
* @param param The request object
*/
public listRUMOperations(
Expand All @@ -1730,8 +1731,8 @@ export class RUMOperationsApi {
}

/**
* List strong links between RUM operations and features. A strong link confirms that a feature
* belongs to an operation. Provide `operation_id`, `feature_id`, or both to filter results;
* List links between RUM operations and journeys. A link confirms that a journey
* belongs to an operation. Provide `operation_id`, `feature_id` (journey ID), or both to filter results;
* at least one is required.
* @param param The request object
*/
Expand Down Expand Up @@ -1782,7 +1783,7 @@ export class RUMOperationsApi {
}

/**
* Update the status of a strong link between a RUM operation and a feature.
* Update the status of a link between a RUM operation and a journey.
* @param param The request object
*/
public updateRUMOperationStrongLink(
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RUMOperationRequestAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class RUMOperationRequestAttributes {
*/
"displayName"?: string;
/**
* The list of feature IDs associated with the RUM operation.
* The list of journey IDs associated with the RUM operation.
*/
"featureIds"?: Array<string>;
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RUMOperationResponseAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class RUMOperationResponseAttributes {
*/
"displayName"?: string;
/**
* The list of feature IDs associated with the RUM operation.
* The list of journey IDs associated with the RUM operation.
*/
"featureIds"?: Array<string>;
/**
Expand Down
4 changes: 2 additions & 2 deletions packages/datadog-api-client-v2/models/RUMOperationStrongLinkCreateRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ import { RUMOperationStrongLinkCreateRequestData } from "./RUMOperationStrongLin
import { AttributeTypeMap } from "../../datadog-api-client-common/util";

/**
* The request body for creating a RUM operation strong link.
* The request body for creating a RUM operation link.
*/
export class RUMOperationStrongLinkCreateRequest {
/**
* The data object for creating a RUM operation strong link.
* The data object for creating a RUM operation link.
*/
"data": RUMOperationStrongLinkCreateRequestData;

Expand Down
Loading
Loading