Skip to content

test(ffe): use canonical FFE fixtures - #8616

Merged
leoromanovsky merged 15 commits into
masterfrom
leo.romanovsky/ffe-canonical-fixtures-20260512
Aug 14, 2026
Merged

test(ffe): use canonical FFE fixtures#8616
leoromanovsky merged 15 commits into
masterfrom
leo.romanovsky/ffe-canonical-fixtures-20260512

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Use the shared FFE fixture corpus so the .NET evaluator is checked against the same behavior as the other tracer implementations. This reduces fixture drift and gives us a repeatable way to expose and correct evaluator bugs when new canonical cases are added.

The same fixture corpus is used by Java, libdatadog, Go, Python, JavaScript, and Ruby.

Changes

  • Replace the legacy copied fixtures with a generated, checked-in snapshot from DataDog/ffe-system-test-data.
  • Record the exact upstream commit in SOURCE.md.
  • Add a script that fetches, validates, and copies the canonical configuration and evaluation cases.
  • Add a weekly and manually dispatchable workflow that opens a signed draft dependency PR only when fixture contents have changed.
  • Parse flags independently so malformed flags do not reject valid neighbors.
  • Return FLAG_NOT_FOUND for missing flags and classify temporal, static, and split allocations.
  • Assert canonical values and reasons through the existing .NET unit-test suite.

Fixture update flow

When we add or change shared evaluator behavior, I imagine the flow working like this:

  1. Add the new configuration and evaluation cases to DataDog/ffe-system-test-data and review the expected behavior there.
  2. The weekly updater, or a manually dispatched run for a specific ref, fetches the canonical repository and compares its fixture contents with the checked-in .NET snapshot.
  3. If nothing changed, the workflow exits without opening or updating a PR.
  4. If fixtures changed, the workflow copies them into this repository, records the source commit, and opens a signed draft PR with the normal dependency labels.
  5. The .NET unit tests run against the updated cases. New tests may intentionally fail when they catch an evaluator bug or unsupported behavior.
  6. Address those evaluator failures in the same dependency PR, keeping the fixture expectations unchanged unless the shared expectation itself is incorrect.
  7. Merge the update once the .NET evaluator satisfies the new canonical cases.

This keeps new behavior explicit and reviewable: fixture changes land in the canonical repository first, and each tracer then gets a visible compatibility PR rather than silently changing at build time.

Decisions

  • DataDog/ffe-system-test-data remains the canonical source of shared evaluator behavior.
  • Keep the generated snapshot checked in so local and CI unit tests do not require network access or submodule initialization.
  • Use a scheduled dependency-update workflow instead of a git submodule.
  • Treat failures introduced by new canonical fixtures as useful regression signals and fix the evaluator as part of accepting the update.
  • Do not create a PR when the canonical fixture contents are unchanged, even if the upstream repository has unrelated commits.

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8616) and master.

✅ No regressions detected

📄 View the full report (charts + all metrics) →

@pr-commenter

pr-commenter Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-14 04:26:42

Comparing candidate commit 30f66cb in PR branch leo.romanovsky/ffe-canonical-fixtures-20260512 with baseline commit b18aab8 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 3 performance regressions! Performance is the same for 69 metrics, 0 unstable metrics, 67 known flaky benchmarks, 59 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartActiveSpan net472

  • 🟥 throughput [-12507.544op/s; -10776.196op/s] or [-6.585%; -5.674%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 throughput [-26633.475op/s; -23588.240op/s] or [-7.501%; -6.644%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-5202.012op/s; -4551.946op/s] or [-5.938%; -5.196%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1

  • 🟥 throughput [-31129.385op/s; -17039.111op/s] or [-13.900%; -7.609%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • 🟥 throughput [-23410.079op/s; -12003.208op/s] or [-11.841%; -6.071%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • 🟥 throughput [-23914.011op/s; -15162.972op/s] or [-11.141%; -7.064%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-8745.118op/s; -8219.341op/s] or [-10.369%; -9.746%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-9041.252op/s; -7681.854op/s] or [-9.193%; -7.811%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+314.608ms; +319.141ms] or [+156.120%; +158.369%]
  • 🟥 throughput [-52.568op/s; -46.886op/s] or [-9.458%; -8.436%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+377.192ms; +381.475ms] or [+298.005%; +301.389%]
  • 🟩 throughput [+88.305op/s; +89.966op/s] or [+11.643%; +11.862%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+394.794ms; +397.388ms] or [+349.377%; +351.674%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.693KB; +4.694KB] or [+98.806%; +98.821%]
  • 🟥 throughput [-61842.030op/s; -61196.180op/s] or [-48.116%; -47.614%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.816KB; +3.816KB] or [+80.699%; +80.711%]
  • 🟩 execution_time [-16.350ms; -12.165ms] or [-7.636%; -5.682%]
  • 🟥 throughput [-59475.951op/s; -56707.430op/s] or [-43.414%; -41.393%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.544KB; +4.544KB] or [+98.261%; +98.274%]
  • 🟥 throughput [-48971.346op/s; -46710.953op/s] or [-44.276%; -42.232%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.315KB; +1.315KB] or [+106.388%; +106.404%]
  • 🟥 throughput [-285217.524op/s; -278377.865op/s] or [-29.122%; -28.424%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+479 bytes; +480 bytes] or [+39.212%; +39.221%]
  • 🟩 execution_time [-26.590ms; -16.691ms] or [-11.858%; -7.443%]
  • 🟥 throughput [-96362.936op/s; -60622.404op/s] or [-10.295%; -6.476%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.280KB; +1.280KB] or [+105.947%; +105.963%]
  • 🟥 throughput [-158124.876op/s; -141899.233op/s] or [-22.720%; -20.388%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-72798.860op/s; -72044.602op/s] or [-48.993%; -48.485%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-73264.679op/s; -70374.187op/s] or [-46.617%; -44.778%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-56046.233op/s; -53432.543op/s] or [-44.648%; -42.566%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+353548.176op/s; +369961.082op/s] or [+11.789%; +12.336%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.793ms; -14.463ms] or [-8.663%; -6.667%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.756KB] or [-42.324%; -42.316%]
  • 🟥 execution_time [+300.448ms; +301.119ms] or [+150.124%; +150.459%]
  • 🟩 throughput [+1010.735op/s; +1030.052op/s] or [+11.163%; +11.377%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+299.099ms; +302.361ms] or [+150.836%; +152.482%]
  • 🟩 throughput [+2367.222op/s; +2584.139op/s] or [+18.106%; +19.765%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.348ms; +302.734ms] or [+151.292%; +152.494%]
  • 🟩 throughput [+1769.309op/s; +1895.882op/s] or [+17.082%; +18.304%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.497ms; +298.281ms] or [+145.628%; +146.504%]
  • 🟩 throughput [+584.418op/s; +596.734op/s] or [+15.493%; +15.820%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+295.695ms; +298.738ms] or [+144.554%; +146.042%]
  • 🟩 throughput [+2467.015op/s; +2629.119op/s] or [+35.841%; +38.196%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+300.938ms; +301.967ms] or [+150.408%; +150.923%]
  • 🟩 throughput [+1369.232op/s; +1392.186op/s] or [+27.178%; +27.634%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-146.462µs; -142.750µs] or [-30.071%; -29.308%]
  • 🟩 throughput [+855.628op/s; +879.086op/s] or [+41.673%; +42.815%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-133.837µs; -106.990µs] or [-30.696%; -24.538%]
  • 🟩 throughput [+807.115op/s; +933.110op/s] or [+35.090%; +40.568%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-142.704µs; -120.704µs] or [-30.575%; -25.861%]
  • 🟩 throughput [+777.483op/s; +860.407op/s] or [+35.890%; +39.718%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-126.911µs; -122.637µs] or [-34.265%; -33.111%]
  • 🟩 throughput [+1348.025op/s; +1397.917op/s] or [+49.925%; +51.772%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-97.279µs; -72.816µs] or [-31.056%; -23.246%]
  • 🟩 throughput [+1069.906op/s; +1301.741op/s] or [+33.352%; +40.579%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-137.558µs; -115.150µs] or [-37.630%; -31.500%]
  • 🟩 throughput [+1326.161op/s; +1464.089op/s] or [+47.591%; +52.540%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.805ms; +300.603ms] or [+149.633%; +150.032%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+326.666ms; +382.725ms] or [+354.936%; +415.846%]
  • 🟩 throughput [+934.691op/s; +1128.282op/s] or [+7.680%; +9.271%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟥 execution_time [+368.095ms; +371.746ms] or [+279.491%; +282.263%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+326.378ms; +379.874ms] or [+150.065%; +174.662%]
  • 🟥 throughput [-526.184op/s; -479.350op/s] or [-47.677%; -43.434%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+210.088ms; +343.365ms] or [+89.530%; +146.328%]
  • 🟥 throughput [-671.137op/s; -587.611op/s] or [-44.765%; -39.194%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • unstable execution_time [+254.937ms; +317.026ms] or [+152.482%; +189.618%]
  • 🟥 throughput [-433.543op/s; -395.896op/s] or [-30.187%; -27.566%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 throughput [+35.277op/s; +40.719op/s] or [+5.135%; +5.927%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • unstable throughput [+15.150op/s; +52.151op/s] or [+4.355%; +14.991%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-166.195µs; -122.046µs] or [-8.419%; -6.182%]
  • 🟩 throughput [+35.123op/s; +46.389op/s] or [+6.934%; +9.158%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+303.190ms; +304.622ms] or [+152.681%; +153.402%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+301.871ms; +302.914ms] or [+151.268%; +151.791%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.003ms; +304.758ms] or [+151.211%; +153.098%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+299.882ms; +301.749ms] or [+150.591%; +151.528%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.063ms; +300.137ms] or [+147.379%; +148.404%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+302.248ms; +306.066ms] or [+153.192%; +155.128%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+302.205ms; +304.127ms] or [+151.680%; +152.644%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+296.381ms; +299.373ms] or [+147.719%; +149.210%]
  • 🟩 throughput [+39959.701op/s; +49527.767op/s] or [+7.935%; +9.835%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+300.283ms; +303.477ms] or [+149.388%; +150.977%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.114ms; -12.466ms] or [-7.493%; -5.797%]
  • 🟩 throughput [+23760.783op/s; +30691.701op/s] or [+6.518%; +8.420%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+11.472µs; +53.563µs] or [+2.834%; +13.230%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.088KB; -19.064KB] or [-6.963%; -6.954%]
  • unstable execution_time [-37.265µs; +20.947µs] or [-7.365%; +4.140%]
  • unstable throughput [-70.204op/s; +132.788op/s] or [-3.503%; +6.626%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-59.121µs; +3.652µs] or [-10.245%; +0.633%]
  • unstable throughput [+5.043op/s; +180.996op/s] or [+0.288%; +10.341%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+5.251µs; +9.616µs] or [+12.412%; +22.729%]
  • 🟥 throughput [-4420.875op/s; -2579.291op/s] or [-18.610%; -10.858%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.412µs; -4.994µs] or [-20.809%; -7.748%]
  • unstable throughput [+1289.968op/s; +3092.223op/s] or [+7.914%; +18.972%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.383ms; +302.471ms] or [+151.830%; +152.886%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.363ms; +303.843ms] or [+153.393%; +154.655%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+300.794ms; +302.976ms] or [+150.585%; +151.677%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+296.797ms; +299.212ms] or [+147.926%; +149.130%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+300.806ms; +303.683ms] or [+151.050%; +152.495%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+301.633ms; +304.009ms] or [+152.969%; +154.174%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.375ms; +301.352ms] or [+149.829%; +150.316%]
  • 🟩 throughput [+66045645.828op/s; +66384246.273op/s] or [+48.099%; +48.345%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+420.749ms; +424.693ms] or [+523.277%; +528.182%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+300.350ms; +301.515ms] or [+149.808%; +150.389%]
  • 🟩 throughput [+13542187.399op/s; +17262596.417op/s] or [+5.998%; +7.646%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+98023.014op/s; +105384.883op/s] or [+9.152%; +9.839%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+65081.919op/s; +73456.400op/s] or [+6.464%; +7.295%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+56205.586op/s; +60436.625op/s] or [+10.206%; +10.974%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

andrewlock
andrewlock requested changes May 13, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use git submodules. We'd rather have a job that periodically pulls in the data from other projects if that's the desired approach.

Alternatively, we can use the system-tests approach which clones the other repo and runs tests against it in CI, if that's a possibility

@leoromanovsky leoromanovsky changed the title Use canonical FFE fixtures test(ffe): use canonical FFE fixtures May 13, 2026
@leoromanovsky
leoromanovsky force-pushed the leo.romanovsky/ffe-canonical-fixtures-20260512 branch from 834879c to 280cbd9 Compare July 30, 2026 01:34
This was referenced Jul 30, 2026
Draft
Draft
Merged
Open
Draft
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/dd-trace-go that referenced this pull request Jul 31, 2026
@leoromanovsky
test(openfeature): use canonical FFE fixtures (#4753)
6d96ff5 
## Motivation

Use the shared FFE fixture corpus. This prevents copied Go fixtures from drifting from other SDKs.

The same migration is merged in [Java](DataDog/dd-trace-java#11355) and [libdatadog](DataDog/libdatadog#1979). Related migrations are open for [Python](DataDog/dd-trace-py#19390), [JavaScript](DataDog/dd-trace-js#8441), [Ruby](DataDog/dd-trace-rb#5742), and [.NET](DataDog/dd-trace-dotnet#8616).

## Changes and Decisions

- Add `DataDog/ffe-system-test-data` as an OpenFeature test submodule.
- Read all canonical configuration and evaluation cases from the submodule.
- Parse and validate flags independently so one invalid flag does not reject valid neighbors.
- Assert canonical values and reasons, including temporal defaults and missing-flag errors.
- Initialize submodules in Go test workflows and configure weekly Dependabot updates.

Co-authored-by: leo.romanovsky <leo.romanovsky@datadoghq.com>
@leoromanovsky
leoromanovsky marked this pull request as ready for review August 11, 2026 14:27
@leoromanovsky
leoromanovsky requested review from a team as code owners August 11, 2026 14:27
@leoromanovsky
leoromanovsky requested review from btthomas and dd-oleksii and removed request for a team August 11, 2026 14:27
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 11, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4765eaabb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/update-ffe-fixtures.sh Outdated
Comment thread .github/workflows/update_ffe_fixtures.yml Outdated
@leoromanovsky leoromanovsky mentioned this pull request Aug 11, 2026
Closed
andrewlock
andrewlock approved these changes Aug 12, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, with some suggestions.

Thanks for following through with this approach! 🙂

Comment thread .github/scripts/update-ffe-fixtures.sh Outdated
Comment thread .github/workflows/update_ffe_fixtures.yml Outdated
Comment thread .github/workflows/update_ffe_fixtures.yml Outdated
Comment thread .github/workflows/update_ffe_fixtures.yml Outdated
Comment thread tracer/src/Datadog.Trace/FeatureFlags/Rcm/Model/ConditionConfiguration.cs
Comment thread tracer/src/Datadog.Trace/FeatureFlags/Rcm/Model/FlagDictionaryJsonConverter.cs Outdated
Comment thread tracer/src/Datadog.Trace/FeatureFlags/Rcm/Model/FlagDictionaryJsonConverter.cs Outdated
Comment thread tracer/src/Datadog.Trace/FeatureFlags/Rcm/Model/FlagDictionaryJsonConverter.cs Outdated
Comment thread tracer/src/Datadog.Trace/FeatureFlags/Rcm/Model/ServerConfiguration.cs Outdated
Comment thread tracer/test/Datadog.Trace.Tests/FeatureFlags/ffe-system-test-data/LICENSE-3rdparty.csv Outdated
@leoromanovsky

leoromanovsky commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @andrewlock . After taking another look, I agreed that representing an invalid flag as a nullable Flag value was undesirable: it encoded parsing state through null and exposed an awkward Dictionary<string, Flag?> interface and required too much downstream protection. I'm not a proficient dotnet developer but this isn't a pattern I enjoy using in other languages.

I replaced it with an explicit three-state lookup: Found, Invalid, or NotFound. This lets us distinguish malformed flags from genuinely missing flags:

  • Invalid flags return PARSE_ERROR.
  • Missing flags return FLAG_NOT_FOUND.
  • Valid flags in the same UFC continue working.

@leoromanovsky
leoromanovsky enabled auto-merge (squash) August 14, 2026 04:30
@leoromanovsky
leoromanovsky merged commit f33ee47 into master Aug 14, 2026
139 of 140 checks passed
@leoromanovsky
leoromanovsky deleted the leo.romanovsky/ffe-canonical-fixtures-20260512 branch August 14, 2026 05:04
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 14, 2026
This was referenced Aug 14, 2026
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@andrewlock andrewlock andrewlock approved these changes
@btthomas btthomas Awaiting requested review from btthomas btthomas is a code owner automatically assigned from DataDog/feature-flagging-and-experimentation-sdk
@dd-oleksii dd-oleksii Awaiting requested review from dd-oleksii dd-oleksii is a code owner automatically assigned from DataDog/feature-flagging-and-experimentation-sdk

Assignees

No one assigned

Labels

type:refactor

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

2 participants

@leoromanovsky @andrewlock