[Profiler] Fix possible namepipe-related issues#8821
Open
chrisnas wants to merge 5 commits into
Open
Conversation
- Fix invalid data injection
github-actions
Bot
added
the
area:profiler
chrisnas
changed the title
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8821) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (72ms) : 68, 77
master - mean (70ms) : 68, 72
section Bailout
This PR (8821) - mean (75ms) : 73, 77
master - mean (74ms) : 72, 75
section CallTarget+Inlining+NGEN
This PR (8821) - mean (1,086ms) : 1032, 1141
master - mean (1,084ms) : 1039, 1129
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (112ms) : 105, 120
master - mean (109ms) : 106, 112
section Bailout
This PR (8821) - mean (110ms) : 108, 113
master - mean (111ms) : 109, 112
section CallTarget+Inlining+NGEN
This PR (8821) - mean (778ms) : 760, 795
master - mean (780ms) : 755, 804
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (101ms) : 94, 107
master - mean (100ms) : 93, 107
section Bailout
This PR (8821) - mean (99ms) : 95, 103
master - mean (99ms) : 94, 104
section CallTarget+Inlining+NGEN
This PR (8821) - mean (945ms) : 907, 983
master - mean (939ms) : 900, 979
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (94ms) : 92, 97
master - mean (94ms) : 92, 97
section Bailout
This PR (8821) - mean (100ms) : 93, 106
master - mean (98ms) : 92, 103
section CallTarget+Inlining+NGEN
This PR (8821) - mean (812ms) : 775, 849
master - mean (813ms) : 781, 845
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (200ms) : 194, 205
master - mean (203ms) : 197, 208
section Bailout
This PR (8821) - mean (203ms) : 199, 207
master - mean (206ms) : 202, 210
section CallTarget+Inlining+NGEN
This PR (8821) - mean (1,207ms) : 1155, 1260
master - mean (1,216ms) : 1153, 1279
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (287ms) : 281, 293
master - mean (289ms) : 282, 296
section Bailout
This PR (8821) - mean (287ms) : 282, 293
master - mean (291ms) : 287, 295
section CallTarget+Inlining+NGEN
This PR (8821) - mean (966ms) : 949, 983
master - mean (973ms) : 953, 994
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (281ms) : 275, 287
master - mean (284ms) : 278, 290
section Bailout
This PR (8821) - mean (281ms) : 274, 287
master - mean (284ms) : 277, 290
section CallTarget+Inlining+NGEN
This PR (8821) - mean (1,165ms) : 1130, 1201
master - mean (1,175ms) : 1138, 1211
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8821) - mean (278ms) : 271, 285
master - mean (280ms) : 275, 284
section Bailout
This PR (8821) - mean (277ms) : 272, 283
master - mean (282ms) : 278, 286
section CallTarget+Inlining+NGEN
This PR (8821) - mean (1,041ms) : 995, 1088
master - mean (1,048ms) : 1004, 1092
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-07-07 09:23:32 Comparing candidate commit 58a68a2 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 60 known flaky benchmarks, 66 flaky benchmarks without significant changes.
|
bouwkast
reviewed
Jul 7, 2026
| // Refuse to continue so we never end up attaching to an impersonated pipe. | ||
| if (lastError == ERROR_ACCESS_DENIED) | ||
| { | ||
| pThis->ShowLastError("Failed to create named pipe: the name is already in use (possible squatting); aborting...", lastError); |
Collaborator
There was a problem hiding this comment.
Does this actually block the startup when there is already the pipe created?
Contributor
Author
There was a problem hiding this comment.
It means that we won't get any event from the agent but the profiler will still be working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
New tests have been added
Other details