Skip to content

[Feature Flags] Support semantic version operators #8993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
greghuels wants to merge 2 commits into from
Closed

[Feature Flags] Support semantic version operators #8993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a483f1
[Feature Flags] Support semantic version operators
greghuels Aug 4, 2026
9cae631
[Feature Flags] Add semver evaluator test coverage
greghuels Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tracer/src/Datadog.Trace/FeatureFlags/FeatureFlagsEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,13 @@ private static bool EvaluateCondition(ConditionConfiguration condition, Evaluati
return CompareNumber(attributeValue, condition.Value, (a, b) => a <= b);
case ConditionOperator.LT:
return CompareNumber(attributeValue, condition.Value, (a, b) => a < b);
case ConditionOperator.SEMVER_EQ:
case ConditionOperator.SEMVER_NEQ:
case ConditionOperator.SEMVER_LT:
case ConditionOperator.SEMVER_LTE:
case ConditionOperator.SEMVER_GT:
case ConditionOperator.SEMVER_GTE:
return CompareSemanticVersion(attributeValue, condition.Value, condition.Operator.Value);
default:
throw new FormatException($"Unknown condition operator {condition.Operator.ToString()}");
}
Expand Down Expand Up @@ -371,6 +378,29 @@ private static bool CompareNumber(object attributeValue, object? conditionValue,
return comparator(a, b);
}

internal static bool CompareSemanticVersion(object attributeValue, object? conditionValue, ConditionOperator conditionOperator)
{
if (attributeValue is not string attribute
|| conditionValue is not string comparand
|| !SemanticVersion.TryParse(attribute, out var attributeVersion)
|| !SemanticVersion.TryParse(comparand, out var comparandVersion))
{
return false;
}

var ordering = attributeVersion.CompareTo(comparandVersion);
return conditionOperator switch
{
ConditionOperator.SEMVER_EQ => ordering == 0,
ConditionOperator.SEMVER_NEQ => ordering != 0,
ConditionOperator.SEMVER_LT => ordering < 0,
ConditionOperator.SEMVER_LTE => ordering <= 0,
ConditionOperator.SEMVER_GT => ordering > 0,
ConditionOperator.SEMVER_GTE => ordering >= 0,
_ => false,
};
}

private static bool MatchesShard(Shard shard, string? targetingKey)
{
if (shard.Ranges is null)
Expand Down
6 changes: 6 additions & 0 deletions tracer/src/Datadog.Trace/FeatureFlags/Rcm/Model/ConditionOperator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ internal enum ConditionOperator
LTE,
GT,
GTE,
SEMVER_EQ,
SEMVER_NEQ,
SEMVER_LT,
SEMVER_LTE,
SEMVER_GT,
SEMVER_GTE,
MATCHES,
NOT_MATCHES,
ONE_OF,
Expand Down
Loading
Loading