Skip to content

chore(openfeature): expand CODEOWNERS coverage - #5131

Merged
darccio merged 2 commits into
mainfrom
agent/ffe-codeowners-coverage
Aug 10, 2026
Merged

chore(openfeature): expand CODEOWNERS coverage#5131
darccio merged 2 commits into
mainfrom
agent/ffe-codeowners-coverage

Conversation

@leoromanovsky

Copy link
Copy Markdown
Contributor

Motivation

The FFE team owns the OpenFeature behavior, but changes under internal/openfeature do not request FFE review. This creates an ownership gap.

Changes and Decisions

Add the FFE SDK team as the code owner for internal/openfeature. Keep all shared Go ownership unchanged.

@datadog-official

datadog-official Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 64.71% (-3.95%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8b917b1 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 4, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-07 21:12:39

Comparing candidate commit 8b917b1 in PR branch agent/ffe-codeowners-coverage with baseline commit b61a63b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 326 metrics, 0 unstable metrics, 1 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

Known flaky benchmarks without significant changes:

  • scenario:BenchmarkOTLPTraceWriterFlush

@leoromanovsky
leoromanovsky marked this pull request as ready for review August 7, 2026 20:42
@leoromanovsky
leoromanovsky requested a review from a team as a code owner August 7, 2026 20:42
@darccio
darccio merged commit 5452f65 into main Aug 10, 2026
198 of 203 checks passed
@darccio
darccio deleted the agent/ffe-codeowners-coverage branch August 10, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants