Revert RMI instrumentation deactivation (#10897)#10936
Revert RMI instrumentation deactivation (#10897)#10936gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056436
Total [baseline] (8.912 s) : 0, 8912390
Agent [candidate] (1.065 s) : 0, 1064535
Total [candidate] (8.878 s) : 0, 8877905
section iast
Agent [baseline] (1.236 s) : 0, 1235758
Total [baseline] (9.579 s) : 0, 9578876
Agent [candidate] (1.229 s) : 0, 1229290
Total [candidate] (9.602 s) : 0, 9601716
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (629.435 ms) : 0, 629435
BytebuddyAgent [candidate] (633.904 ms) : 0, 633904
AgentMeter [baseline] (29.482 ms) : 0, 29482
AgentMeter [candidate] (29.668 ms) : 0, 29668
GlobalTracer [baseline] (256.995 ms) : 0, 256995
GlobalTracer [candidate] (259.064 ms) : 0, 259064
AppSec [baseline] (31.582 ms) : 0, 31582
AppSec [candidate] (32.103 ms) : 0, 32103
Debugger [baseline] (59.672 ms) : 0, 59672
Debugger [candidate] (59.989 ms) : 0, 59989
Remote Config [baseline] (582.393 µs) : 0, 582
Remote Config [candidate] (590.694 µs) : 0, 591
Telemetry [baseline] (7.995 ms) : 0, 7995
Telemetry [candidate] (8.118 ms) : 0, 8118
Flare Poller [baseline] (3.491 ms) : 0, 3491
Flare Poller [candidate] (3.546 ms) : 0, 3546
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (802.014 ms) : 0, 802014
BytebuddyAgent [candidate] (797.664 ms) : 0, 797664
AgentMeter [baseline] (11.636 ms) : 0, 11636
AgentMeter [candidate] (11.408 ms) : 0, 11408
GlobalTracer [baseline] (248.616 ms) : 0, 248616
GlobalTracer [candidate] (247.808 ms) : 0, 247808
AppSec [baseline] (26.767 ms) : 0, 26767
AppSec [candidate] (27.378 ms) : 0, 27378
Debugger [baseline] (68.459 ms) : 0, 68459
Debugger [candidate] (67.954 ms) : 0, 67954
Remote Config [baseline] (531.778 µs) : 0, 532
Remote Config [candidate] (523.973 µs) : 0, 524
Telemetry [baseline] (10.804 ms) : 0, 10804
Telemetry [candidate] (10.422 ms) : 0, 10422
Flare Poller [baseline] (3.799 ms) : 0, 3799
Flare Poller [candidate] (3.525 ms) : 0, 3525
IAST [baseline] (25.639 ms) : 0, 25639
IAST [candidate] (25.321 ms) : 0, 25321
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060646
Total [baseline] (11.074 s) : 0, 11074266
Agent [candidate] (1.066 s) : 0, 1066105
Total [candidate] (11.153 s) : 0, 11153093
section appsec
Agent [baseline] (1.252 s) : 0, 1251939
Total [baseline] (11.154 s) : 0, 11154487
Agent [candidate] (1.249 s) : 0, 1248800
Total [candidate] (11.081 s) : 0, 11080547
section iast
Agent [baseline] (1.228 s) : 0, 1228076
Total [baseline] (11.35 s) : 0, 11350206
Agent [candidate] (1.24 s) : 0, 1239692
Total [candidate] (11.381 s) : 0, 11380979
section profiling
Agent [baseline] (1.184 s) : 0, 1184425
Total [baseline] (11.082 s) : 0, 11081939
Agent [candidate] (1.184 s) : 0, 1183517
Total [candidate] (11.028 s) : 0, 11027838
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (629.622 ms) : 0, 629622
BytebuddyAgent [candidate] (634.174 ms) : 0, 634174
AgentMeter [baseline] (29.358 ms) : 0, 29358
AgentMeter [candidate] (29.677 ms) : 0, 29677
GlobalTracer [baseline] (256.979 ms) : 0, 256979
GlobalTracer [candidate] (258.93 ms) : 0, 258930
AppSec [baseline] (31.638 ms) : 0, 31638
AppSec [candidate] (31.981 ms) : 0, 31981
Debugger [baseline] (60.523 ms) : 0, 60523
Debugger [candidate] (60.872 ms) : 0, 60872
Remote Config [baseline] (585.0 µs) : 0, 585
Remote Config [candidate] (593.636 µs) : 0, 594
Telemetry [baseline] (9.588 ms) : 0, 9588
Telemetry [candidate] (8.091 ms) : 0, 8091
Flare Poller [baseline] (5.152 ms) : 0, 5152
Flare Poller [candidate] (4.363 ms) : 0, 4363
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (661.455 ms) : 0, 661455
BytebuddyAgent [candidate] (659.757 ms) : 0, 659757
AgentMeter [baseline] (12.15 ms) : 0, 12150
AgentMeter [candidate] (12.114 ms) : 0, 12114
GlobalTracer [baseline] (258.996 ms) : 0, 258996
GlobalTracer [candidate] (258.405 ms) : 0, 258405
AppSec [baseline] (178.328 ms) : 0, 178328
AppSec [candidate] (177.821 ms) : 0, 177821
Debugger [baseline] (66.612 ms) : 0, 66612
Debugger [candidate] (66.469 ms) : 0, 66469
Remote Config [baseline] (631.99 µs) : 0, 632
Remote Config [candidate] (623.594 µs) : 0, 624
Telemetry [baseline] (8.338 ms) : 0, 8338
Telemetry [candidate] (8.336 ms) : 0, 8336
Flare Poller [baseline] (3.586 ms) : 0, 3586
Flare Poller [candidate] (3.576 ms) : 0, 3576
IAST [baseline] (24.256 ms) : 0, 24256
IAST [candidate] (24.142 ms) : 0, 24142
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (796.207 ms) : 0, 796207
BytebuddyAgent [candidate] (804.7 ms) : 0, 804700
AgentMeter [baseline] (11.379 ms) : 0, 11379
AgentMeter [candidate] (11.569 ms) : 0, 11569
GlobalTracer [baseline] (247.387 ms) : 0, 247387
GlobalTracer [candidate] (249.636 ms) : 0, 249636
AppSec [baseline] (26.443 ms) : 0, 26443
AppSec [candidate] (26.801 ms) : 0, 26801
Debugger [baseline] (70.249 ms) : 0, 70249
Debugger [candidate] (70.833 ms) : 0, 70833
Remote Config [baseline] (530.212 µs) : 0, 530
Remote Config [candidate] (536.826 µs) : 0, 537
Telemetry [baseline] (9.709 ms) : 0, 9709
Telemetry [candidate] (9.155 ms) : 0, 9155
Flare Poller [baseline] (3.497 ms) : 0, 3497
Flare Poller [candidate] (3.349 ms) : 0, 3349
IAST [baseline] (25.307 ms) : 0, 25307
IAST [candidate] (25.54 ms) : 0, 25540
section profiling
ProfilingAgent [baseline] (93.79 ms) : 0, 93790
ProfilingAgent [candidate] (93.637 ms) : 0, 93637
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (683.981 ms) : 0, 683981
BytebuddyAgent [candidate] (683.74 ms) : 0, 683740
AgentMeter [baseline] (9.004 ms) : 0, 9004
AgentMeter [candidate] (9.055 ms) : 0, 9055
GlobalTracer [baseline] (215.71 ms) : 0, 215710
GlobalTracer [candidate] (215.166 ms) : 0, 215166
AppSec [baseline] (32.211 ms) : 0, 32211
AppSec [candidate] (32.195 ms) : 0, 32195
Debugger [baseline] (65.839 ms) : 0, 65839
Debugger [candidate] (65.077 ms) : 0, 65077
Remote Config [baseline] (561.073 µs) : 0, 561
Remote Config [candidate] (561.443 µs) : 0, 561
Telemetry [baseline] (7.744 ms) : 0, 7744
Telemetry [candidate] (8.477 ms) : 0, 8477
Flare Poller [baseline] (3.493 ms) : 0, 3493
Flare Poller [candidate] (3.469 ms) : 0, 3469
Profiling [baseline] (94.348 ms) : 0, 94348
Profiling [candidate] (94.191 ms) : 0, 94191
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (19.144 ms) : 18951, 19337
. : milestone, 19144,
appsec (19.683 ms) : 19483, 19884
. : milestone, 19683,
code_origins (17.91 ms) : 17733, 18087
. : milestone, 17910,
iast (17.847 ms) : 17672, 18022
. : milestone, 17847,
profiling (18.562 ms) : 18375, 18749
. : milestone, 18562,
tracing (17.779 ms) : 17603, 17956
. : milestone, 17779,
section candidate
no_agent (18.28 ms) : 18094, 18466
. : milestone, 18280,
appsec (18.498 ms) : 18310, 18687
. : milestone, 18498,
code_origins (17.958 ms) : 17779, 18136
. : milestone, 17958,
iast (18.954 ms) : 18763, 19145
. : milestone, 18954,
profiling (20.339 ms) : 20134, 20544
. : milestone, 20339,
tracing (17.889 ms) : 17710, 18068
. : milestone, 17889,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (1.168 ms) : 1157, 1179
. : milestone, 1168,
iast (3.228 ms) : 3185, 3271
. : milestone, 3228,
iast_FULL (5.963 ms) : 5904, 6023
. : milestone, 5963,
iast_GLOBAL (3.583 ms) : 3534, 3632
. : milestone, 3583,
profiling (2.228 ms) : 2207, 2250
. : milestone, 2228,
tracing (1.778 ms) : 1764, 1792
. : milestone, 1778,
section candidate
no_agent (1.178 ms) : 1167, 1188
. : milestone, 1178,
iast (3.229 ms) : 3184, 3274
. : milestone, 3229,
iast_FULL (6.063 ms) : 6002, 6125
. : milestone, 6063,
iast_GLOBAL (3.592 ms) : 3532, 3652
. : milestone, 3592,
profiling (1.993 ms) : 1976, 2010
. : milestone, 1993,
tracing (1.795 ms) : 1780, 1810
. : milestone, 1795,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
appsec (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
iast (18.388 s) : 18388000, 18388000
. : milestone, 18388000,
iast_GLOBAL (17.811 s) : 17811000, 17811000
. : milestone, 17811000,
profiling (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
tracing (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
section candidate
no_agent (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
appsec (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
iast (18.178 s) : 18178000, 18178000
. : milestone, 18178000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
tracing (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~ec9d8b5a95, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.807 ms) : 3585, 4028
. : milestone, 3807,
iast (2.25 ms) : 2182, 2319
. : milestone, 2250,
iast_GLOBAL (2.296 ms) : 2227, 2365
. : milestone, 2296,
profiling (2.115 ms) : 2058, 2171
. : milestone, 2115,
tracing (2.059 ms) : 2006, 2112
. : milestone, 2059,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.785 ms) : 3565, 4005
. : milestone, 3785,
iast (2.259 ms) : 2191, 2328
. : milestone, 2259,
iast_GLOBAL (2.292 ms) : 2223, 2360
. : milestone, 2292,
profiling (2.073 ms) : 2019, 2127
. : milestone, 2073,
tracing (2.057 ms) : 2004, 2110
. : milestone, 2057,
|
This reverts commit ee6b3da.
a06bdb8 to
ec9d8b5
Compare
|
Rebased instead of merge with master to keep the git history simple. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
cannot trigger DDCI. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This reverts commit ee6b3da.
Motivation
This PR is a follow up of #10935
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.