Cache Tracer Host Entry to reduce allocation in RemoteHostnameAdder#10968
Open
Cache Tracer Host Entry to reduce allocation in RemoteHostnameAdder#10968
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064838
Total [baseline] (8.873 s) : 0, 8872542
Agent [candidate] (1.064 s) : 0, 1063670
Total [candidate] (8.866 s) : 0, 8865593
section iast
Agent [baseline] (1.237 s) : 0, 1236760
Total [baseline] (9.548 s) : 0, 9547890
Agent [candidate] (1.232 s) : 0, 1231987
Total [candidate] (9.591 s) : 0, 9590934
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (634.633 ms) : 0, 634633
BytebuddyAgent [candidate] (630.999 ms) : 0, 630999
AgentMeter [baseline] (29.523 ms) : 0, 29523
AgentMeter [candidate] (29.613 ms) : 0, 29613
GlobalTracer [baseline] (257.898 ms) : 0, 257898
GlobalTracer [candidate] (258.952 ms) : 0, 258952
AppSec [baseline] (31.924 ms) : 0, 31924
AppSec [candidate] (32.073 ms) : 0, 32073
Debugger [baseline] (59.641 ms) : 0, 59641
Debugger [candidate] (59.993 ms) : 0, 59993
Remote Config [baseline] (599.968 µs) : 0, 600
Remote Config [candidate] (582.213 µs) : 0, 582
Telemetry [baseline] (8.083 ms) : 0, 8083
Telemetry [candidate] (8.141 ms) : 0, 8141
Flare Poller [baseline] (5.099 ms) : 0, 5099
Flare Poller [candidate] (5.931 ms) : 0, 5931
section iast
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (803.629 ms) : 0, 803629
BytebuddyAgent [candidate] (800.481 ms) : 0, 800481
AgentMeter [baseline] (11.605 ms) : 0, 11605
AgentMeter [candidate] (11.605 ms) : 0, 11605
GlobalTracer [baseline] (248.621 ms) : 0, 248621
GlobalTracer [candidate] (247.225 ms) : 0, 247225
AppSec [baseline] (26.728 ms) : 0, 26728
AppSec [candidate] (26.593 ms) : 0, 26593
Debugger [baseline] (66.149 ms) : 0, 66149
Debugger [candidate] (69.576 ms) : 0, 69576
Remote Config [baseline] (536.355 µs) : 0, 536
Remote Config [candidate] (530.265 µs) : 0, 530
Telemetry [baseline] (12.442 ms) : 0, 12442
Telemetry [candidate] (9.626 ms) : 0, 9626
Flare Poller [baseline] (4.121 ms) : 0, 4121
Flare Poller [candidate] (3.557 ms) : 0, 3557
IAST [baseline] (25.531 ms) : 0, 25531
IAST [candidate] (25.494 ms) : 0, 25494
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063591
Total [baseline] (11.014 s) : 0, 11014473
Agent [candidate] (1.07 s) : 0, 1070171
Total [candidate] (11.11 s) : 0, 11110272
section appsec
Agent [baseline] (1.246 s) : 0, 1245509
Total [baseline] (11.098 s) : 0, 11097986
Agent [candidate] (1.254 s) : 0, 1253981
Total [candidate] (11.159 s) : 0, 11159409
section iast
Agent [baseline] (1.226 s) : 0, 1225568
Total [baseline] (11.331 s) : 0, 11330896
Agent [candidate] (1.228 s) : 0, 1228050
Total [candidate] (11.221 s) : 0, 11221041
section profiling
Agent [baseline] (1.183 s) : 0, 1182966
Total [baseline] (11.08 s) : 0, 11079801
Agent [candidate] (1.184 s) : 0, 1184188
Total [candidate] (11.042 s) : 0, 11041594
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (633.391 ms) : 0, 633391
BytebuddyAgent [candidate] (634.773 ms) : 0, 634773
AgentMeter [baseline] (29.576 ms) : 0, 29576
AgentMeter [candidate] (29.967 ms) : 0, 29967
GlobalTracer [baseline] (258.278 ms) : 0, 258278
GlobalTracer [candidate] (259.863 ms) : 0, 259863
AppSec [baseline] (31.983 ms) : 0, 31983
AppSec [candidate] (32.338 ms) : 0, 32338
Debugger [baseline] (60.681 ms) : 0, 60681
Debugger [candidate] (61.127 ms) : 0, 61127
Remote Config [baseline] (593.702 µs) : 0, 594
Remote Config [candidate] (592.846 µs) : 0, 593
Telemetry [baseline] (8.153 ms) : 0, 8153
Telemetry [candidate] (8.932 ms) : 0, 8932
Flare Poller [baseline] (3.6 ms) : 0, 3600
Flare Poller [candidate] (5.112 ms) : 0, 5112
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (657.384 ms) : 0, 657384
BytebuddyAgent [candidate] (663.346 ms) : 0, 663346
AgentMeter [baseline] (12.17 ms) : 0, 12170
AgentMeter [candidate] (12.249 ms) : 0, 12249
GlobalTracer [baseline] (257.453 ms) : 0, 257453
GlobalTracer [candidate] (259.11 ms) : 0, 259110
AppSec [baseline] (177.394 ms) : 0, 177394
AppSec [candidate] (178.27 ms) : 0, 178270
Debugger [baseline] (66.035 ms) : 0, 66035
Debugger [candidate] (66.485 ms) : 0, 66485
Remote Config [baseline] (644.525 µs) : 0, 645
Remote Config [candidate] (627.462 µs) : 0, 627
Telemetry [baseline] (8.472 ms) : 0, 8472
Telemetry [candidate] (8.359 ms) : 0, 8359
Flare Poller [baseline] (4.451 ms) : 0, 4451
Flare Poller [candidate] (3.606 ms) : 0, 3606
IAST [baseline] (24.089 ms) : 0, 24089
IAST [candidate] (24.325 ms) : 0, 24325
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (794.804 ms) : 0, 794804
BytebuddyAgent [candidate] (796.748 ms) : 0, 796748
AgentMeter [baseline] (11.372 ms) : 0, 11372
AgentMeter [candidate] (11.434 ms) : 0, 11434
GlobalTracer [baseline] (246.654 ms) : 0, 246654
GlobalTracer [candidate] (247.272 ms) : 0, 247272
AppSec [baseline] (26.572 ms) : 0, 26572
AppSec [candidate] (26.521 ms) : 0, 26521
Debugger [baseline] (70.006 ms) : 0, 70006
Debugger [candidate] (70.474 ms) : 0, 70474
Remote Config [baseline] (530.546 µs) : 0, 531
Remote Config [candidate] (532.811 µs) : 0, 533
Telemetry [baseline] (9.649 ms) : 0, 9649
Telemetry [candidate] (9.151 ms) : 0, 9151
Flare Poller [baseline] (3.496 ms) : 0, 3496
Flare Poller [candidate] (3.355 ms) : 0, 3355
IAST [baseline] (25.272 ms) : 0, 25272
IAST [candidate] (25.301 ms) : 0, 25301
section profiling
crashtracking [baseline] (1.162 ms) : 0, 1162
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (682.381 ms) : 0, 682381
BytebuddyAgent [candidate] (683.998 ms) : 0, 683998
AgentMeter [baseline] (8.962 ms) : 0, 8962
AgentMeter [candidate] (8.944 ms) : 0, 8944
GlobalTracer [baseline] (214.616 ms) : 0, 214616
GlobalTracer [candidate] (214.947 ms) : 0, 214947
AppSec [baseline] (32.353 ms) : 0, 32353
AppSec [candidate] (32.231 ms) : 0, 32231
Debugger [baseline] (66.239 ms) : 0, 66239
Debugger [candidate] (66.136 ms) : 0, 66136
Remote Config [baseline] (573.537 µs) : 0, 574
Remote Config [candidate] (558.235 µs) : 0, 558
Telemetry [baseline] (7.785 ms) : 0, 7785
Telemetry [candidate] (7.725 ms) : 0, 7725
Flare Poller [baseline] (3.556 ms) : 0, 3556
Flare Poller [candidate] (3.52 ms) : 0, 3520
ProfilingAgent [baseline] (94.415 ms) : 0, 94415
ProfilingAgent [candidate] (94.212 ms) : 0, 94212
Profiling [baseline] (94.973 ms) : 0, 94973
Profiling [candidate] (94.769 ms) : 0, 94769
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (19.497 ms) : 19295, 19699
. : milestone, 19497,
appsec (18.658 ms) : 18470, 18846
. : milestone, 18658,
code_origins (17.941 ms) : 17763, 18119
. : milestone, 17941,
iast (17.766 ms) : 17590, 17942
. : milestone, 17766,
profiling (19.437 ms) : 19238, 19636
. : milestone, 19437,
tracing (17.623 ms) : 17447, 17798
. : milestone, 17623,
section candidate
no_agent (17.072 ms) : 16906, 17237
. : milestone, 17072,
appsec (18.585 ms) : 18395, 18774
. : milestone, 18585,
code_origins (17.7 ms) : 17526, 17874
. : milestone, 17700,
iast (17.88 ms) : 17701, 18060
. : milestone, 17880,
profiling (20.329 ms) : 20133, 20525
. : milestone, 20329,
tracing (17.713 ms) : 17536, 17889
. : milestone, 17713,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.176 ms) : 1164, 1187
. : milestone, 1176,
iast (3.211 ms) : 3166, 3255
. : milestone, 3211,
iast_FULL (5.86 ms) : 5802, 5919
. : milestone, 5860,
iast_GLOBAL (3.714 ms) : 3649, 3778
. : milestone, 3714,
profiling (2.094 ms) : 2076, 2113
. : milestone, 2094,
tracing (1.861 ms) : 1845, 1878
. : milestone, 1861,
section candidate
no_agent (1.226 ms) : 1214, 1238
. : milestone, 1226,
iast (3.229 ms) : 3185, 3273
. : milestone, 3229,
iast_FULL (5.939 ms) : 5879, 5999
. : milestone, 5939,
iast_GLOBAL (3.661 ms) : 3598, 3725
. : milestone, 3661,
profiling (2.266 ms) : 2243, 2288
. : milestone, 2266,
tracing (1.849 ms) : 1832, 1867
. : milestone, 1849,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1484
. : milestone, 1472,
appsec (3.785 ms) : 3562, 4008
. : milestone, 3785,
iast (2.252 ms) : 2183, 2321
. : milestone, 2252,
iast_GLOBAL (2.299 ms) : 2229, 2368
. : milestone, 2299,
profiling (2.483 ms) : 2262, 2704
. : milestone, 2483,
tracing (2.063 ms) : 2010, 2117
. : milestone, 2063,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.815 ms) : 3593, 4037
. : milestone, 3815,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.293 ms) : 2223, 2362
. : milestone, 2293,
profiling (2.503 ms) : 2337, 2669
. : milestone, 2503,
tracing (2.067 ms) : 2013, 2120
. : milestone, 2067,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~d8d553e8c0, baseline=1.61.0-SNAPSHOT~a1239d32d8
dateFormat X
axisFormat %s
section baseline
no_agent (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
appsec (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
iast (17.778 s) : 17778000, 17778000
. : milestone, 17778000,
iast_GLOBAL (17.77 s) : 17770000, 17770000
. : milestone, 17770000,
profiling (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
tracing (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
section candidate
no_agent (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
appsec (14.626 s) : 14626000, 14626000
. : milestone, 14626000,
iast (18.032 s) : 18032000, 18032000
. : milestone, 18032000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (14.725 s) : 14725000, 14725000
. : milestone, 14725000,
tracing (14.765 s) : 14765000, 14765000
. : milestone, 14765000,
|
dougqh
commented
Mar 25, 2026
| } | ||
|
|
||
| String hostname = hostnameSupplier.get(); | ||
| if (hostname == null) { |
Contributor
Author
There was a problem hiding this comment.
This is subtle change in behavior from before.
TagMap.put would have failed with an exception when given null.
I've decided to just ignore hostnameSupplier.get returning null instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Cache Tracer Host Entry to reduce allocation in RemoteHostnameAdder
Motivation
Reduce allocation and garbage collection
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.