Support CompletableFuture on Spring Messaging Spans#10979
Open
Support CompletableFuture on Spring Messaging Spans#10979
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061895
Total [baseline] (8.89 s) : 0, 8890230
Agent [candidate] (1.058 s) : 0, 1058323
Total [candidate] (8.893 s) : 0, 8892614
section iast
Agent [baseline] (1.229 s) : 0, 1229161
Total [baseline] (9.567 s) : 0, 9566673
Agent [candidate] (1.24 s) : 0, 1239935
Total [candidate] (9.588 s) : 0, 9587909
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (631.259 ms) : 0, 631259
BytebuddyAgent [candidate] (629.995 ms) : 0, 629995
AgentMeter [baseline] (29.49 ms) : 0, 29490
AgentMeter [candidate] (29.409 ms) : 0, 29409
GlobalTracer [baseline] (258.258 ms) : 0, 258258
GlobalTracer [candidate] (257.439 ms) : 0, 257439
AppSec [baseline] (31.868 ms) : 0, 31868
AppSec [candidate] (32.095 ms) : 0, 32095
Debugger [baseline] (59.95 ms) : 0, 59950
Debugger [candidate] (59.845 ms) : 0, 59845
Remote Config [baseline] (590.15 µs) : 0, 590
Remote Config [candidate] (601.277 µs) : 0, 601
Telemetry [baseline] (8.045 ms) : 0, 8045
Telemetry [candidate] (8.088 ms) : 0, 8088
Flare Poller [baseline] (4.962 ms) : 0, 4962
Flare Poller [candidate] (3.557 ms) : 0, 3557
section iast
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (797.258 ms) : 0, 797258
BytebuddyAgent [candidate] (805.242 ms) : 0, 805242
AgentMeter [baseline] (11.437 ms) : 0, 11437
AgentMeter [candidate] (11.732 ms) : 0, 11732
GlobalTracer [baseline] (247.791 ms) : 0, 247791
GlobalTracer [candidate] (249.786 ms) : 0, 249786
AppSec [baseline] (26.598 ms) : 0, 26598
AppSec [candidate] (26.885 ms) : 0, 26885
Debugger [baseline] (69.383 ms) : 0, 69383
Debugger [candidate] (67.238 ms) : 0, 67238
Remote Config [baseline] (536.906 µs) : 0, 537
Remote Config [candidate] (533.29 µs) : 0, 533
Telemetry [baseline] (9.723 ms) : 0, 9723
Telemetry [candidate] (11.398 ms) : 0, 11398
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.919 ms) : 0, 3919
IAST [baseline] (25.442 ms) : 0, 25442
IAST [candidate] (25.676 ms) : 0, 25676
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061162
Total [baseline] (11.055 s) : 0, 11054614
Agent [candidate] (1.06 s) : 0, 1060187
Total [candidate] (11.071 s) : 0, 11070749
section appsec
Agent [baseline] (1.252 s) : 0, 1251636
Total [baseline] (11.112 s) : 0, 11111514
Agent [candidate] (1.26 s) : 0, 1259991
Total [candidate] (11.274 s) : 0, 11274106
section iast
Agent [baseline] (1.232 s) : 0, 1232476
Total [baseline] (11.341 s) : 0, 11341382
Agent [candidate] (1.248 s) : 0, 1248344
Total [candidate] (11.349 s) : 0, 11348943
section profiling
Agent [baseline] (1.185 s) : 0, 1184585
Total [baseline] (11.038 s) : 0, 11038178
Agent [candidate] (1.186 s) : 0, 1185975
Total [candidate] (11.184 s) : 0, 11184005
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (630.513 ms) : 0, 630513
BytebuddyAgent [candidate] (630.986 ms) : 0, 630986
AgentMeter [baseline] (29.466 ms) : 0, 29466
AgentMeter [candidate] (29.464 ms) : 0, 29464
GlobalTracer [baseline] (257.922 ms) : 0, 257922
GlobalTracer [candidate] (257.676 ms) : 0, 257676
AppSec [baseline] (31.773 ms) : 0, 31773
AppSec [candidate] (31.774 ms) : 0, 31774
Debugger [baseline] (60.524 ms) : 0, 60524
Debugger [candidate] (60.301 ms) : 0, 60301
Remote Config [baseline] (603.197 µs) : 0, 603
Remote Config [candidate] (590.373 µs) : 0, 590
Telemetry [baseline] (8.029 ms) : 0, 8029
Telemetry [candidate] (7.952 ms) : 0, 7952
Flare Poller [baseline] (5.032 ms) : 0, 5032
Flare Poller [candidate] (4.223 ms) : 0, 4223
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (661.299 ms) : 0, 661299
BytebuddyAgent [candidate] (664.867 ms) : 0, 664867
AgentMeter [baseline] (12.249 ms) : 0, 12249
AgentMeter [candidate] (12.24 ms) : 0, 12240
GlobalTracer [baseline] (259.034 ms) : 0, 259034
GlobalTracer [candidate] (260.878 ms) : 0, 260878
IAST [baseline] (24.234 ms) : 0, 24234
IAST [candidate] (24.585 ms) : 0, 24585
AppSec [baseline] (177.931 ms) : 0, 177931
AppSec [candidate] (179.587 ms) : 0, 179587
Debugger [baseline] (66.711 ms) : 0, 66711
Debugger [candidate] (67.246 ms) : 0, 67246
Remote Config [baseline] (640.369 µs) : 0, 640
Remote Config [candidate] (655.857 µs) : 0, 656
Telemetry [baseline] (8.328 ms) : 0, 8328
Telemetry [candidate] (8.596 ms) : 0, 8596
Flare Poller [baseline] (3.61 ms) : 0, 3610
Flare Poller [candidate] (3.691 ms) : 0, 3691
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (799.334 ms) : 0, 799334
BytebuddyAgent [candidate] (810.748 ms) : 0, 810748
AgentMeter [baseline] (11.455 ms) : 0, 11455
AgentMeter [candidate] (12.037 ms) : 0, 12037
GlobalTracer [baseline] (248.576 ms) : 0, 248576
GlobalTracer [candidate] (250.9 ms) : 0, 250900
IAST [baseline] (25.354 ms) : 0, 25354
IAST [candidate] (25.846 ms) : 0, 25846
AppSec [baseline] (26.596 ms) : 0, 26596
AppSec [candidate] (27.041 ms) : 0, 27041
Debugger [baseline] (70.817 ms) : 0, 70817
Debugger [candidate] (70.269 ms) : 0, 70269
Remote Config [baseline] (528.322 µs) : 0, 528
Remote Config [candidate] (533.395 µs) : 0, 533
Telemetry [baseline] (9.172 ms) : 0, 9172
Telemetry [candidate] (9.893 ms) : 0, 9893
Flare Poller [baseline] (3.429 ms) : 0, 3429
Flare Poller [candidate] (3.405 ms) : 0, 3405
section profiling
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (684.192 ms) : 0, 684192
BytebuddyAgent [candidate] (683.983 ms) : 0, 683983
AgentMeter [baseline] (8.995 ms) : 0, 8995
AgentMeter [candidate] (8.993 ms) : 0, 8993
GlobalTracer [baseline] (215.004 ms) : 0, 215004
GlobalTracer [candidate] (215.075 ms) : 0, 215075
AppSec [baseline] (32.204 ms) : 0, 32204
AppSec [candidate] (32.382 ms) : 0, 32382
Debugger [baseline] (65.483 ms) : 0, 65483
Debugger [candidate] (66.105 ms) : 0, 66105
Remote Config [baseline] (582.856 µs) : 0, 583
Remote Config [candidate] (573.767 µs) : 0, 574
Telemetry [baseline] (7.705 ms) : 0, 7705
Telemetry [candidate] (7.898 ms) : 0, 7898
Flare Poller [baseline] (4.287 ms) : 0, 4287
Flare Poller [candidate] (3.516 ms) : 0, 3516
ProfilingAgent [baseline] (94.046 ms) : 0, 94046
ProfilingAgent [candidate] (95.294 ms) : 0, 95294
Profiling [baseline] (94.597 ms) : 0, 94597
Profiling [candidate] (95.867 ms) : 0, 95867
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 6 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (17.985 ms) : 17798, 18172
. : milestone, 17985,
appsec (18.177 ms) : 17993, 18361
. : milestone, 18177,
code_origins (17.83 ms) : 17652, 18009
. : milestone, 17830,
iast (17.703 ms) : 17525, 17881
. : milestone, 17703,
profiling (18.899 ms) : 18709, 19090
. : milestone, 18899,
tracing (17.799 ms) : 17621, 17977
. : milestone, 17799,
section candidate
no_agent (19.387 ms) : 19187, 19588
. : milestone, 19387,
appsec (18.907 ms) : 18713, 19102
. : milestone, 18907,
code_origins (17.913 ms) : 17737, 18089
. : milestone, 17913,
iast (17.698 ms) : 17522, 17873
. : milestone, 17698,
profiling (20.403 ms) : 20187, 20618
. : milestone, 20403,
tracing (17.724 ms) : 17549, 17898
. : milestone, 17724,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (1.191 ms) : 1179, 1203
. : milestone, 1191,
iast (3.11 ms) : 3070, 3151
. : milestone, 3110,
iast_FULL (5.831 ms) : 5773, 5889
. : milestone, 5831,
iast_GLOBAL (3.528 ms) : 3471, 3584
. : milestone, 3528,
profiling (2.202 ms) : 2182, 2222
. : milestone, 2202,
tracing (1.807 ms) : 1792, 1822
. : milestone, 1807,
section candidate
no_agent (1.178 ms) : 1167, 1189
. : milestone, 1178,
iast (3.179 ms) : 3137, 3221
. : milestone, 3179,
iast_FULL (6.135 ms) : 6072, 6198
. : milestone, 6135,
iast_GLOBAL (3.537 ms) : 3486, 3588
. : milestone, 3537,
profiling (2.081 ms) : 2062, 2100
. : milestone, 2081,
tracing (1.848 ms) : 1830, 1865
. : milestone, 1848,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.793 ms) : 3573, 4014
. : milestone, 3793,
iast (2.247 ms) : 2178, 2316
. : milestone, 2247,
iast_GLOBAL (2.289 ms) : 2220, 2358
. : milestone, 2289,
profiling (2.105 ms) : 2048, 2162
. : milestone, 2105,
tracing (2.056 ms) : 2002, 2109
. : milestone, 2056,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.578 ms) : 2520, 2636
. : milestone, 2578,
iast (2.247 ms) : 2178, 2316
. : milestone, 2247,
iast_GLOBAL (2.29 ms) : 2221, 2359
. : milestone, 2290,
profiling (2.097 ms) : 2041, 2154
. : milestone, 2097,
tracing (2.053 ms) : 2000, 2106
. : milestone, 2053,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~7a58426997, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
appsec (14.728 s) : 14728000, 14728000
. : milestone, 14728000,
iast (18.318 s) : 18318000, 18318000
. : milestone, 18318000,
iast_GLOBAL (17.838 s) : 17838000, 17838000
. : milestone, 17838000,
profiling (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
tracing (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
section candidate
no_agent (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
appsec (14.673 s) : 14673000, 14673000
. : milestone, 14673000,
iast (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
iast_GLOBAL (17.833 s) : 17833000, 17833000
. : milestone, 17833000,
profiling (14.651 s) : 14651000, 14651000
. : milestone, 14651000,
tracing (14.782 s) : 14782000, 14782000
. : milestone, 14782000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR updates the
spring-messagingintegration to support Async message handlers. Previously, the message handler would finish the span directly after making the async call. Now, we detect if the call is sync/async, and add awhenCompleteto the span.This reuses previously written code to handle async processing in Spring WebMVC Controllers.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.