Skip to content

Fix WildFly scheduled test race #12385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 3 commits into from
Sep 4, 2026
Merged

Fix WildFly scheduled test race #12385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
076e262
Fix WildFly scheduled test race
AlexeyKuznetsov-DD Sep 2, 2026
21955e3
Merge branch 'master' into alexeyk/fix-wildfly-scheduled-test-race
AlexeyKuznetsov-DD Sep 3, 2026
1f786fa
Clarify WildFly scheduled trace request flag
AlexeyKuznetsov-DD Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dd-smoke-tests/wildfly/spring-ear/war/src/main/java/com/example/Common.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@

public class Common {
// for the sake of this example it avoids boilerplate ton inject an ejb into a spring context
public static final AtomicBoolean ENABLED = new AtomicBoolean(false);
public static final AtomicBoolean TRACE_REQUEST_PENDING = new AtomicBoolean(false);
}
4 changes: 2 additions & 2 deletions dd-smoke-tests/wildfly/spring-ear/war/src/main/java/com/example/ejb/ScheduledEjb.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.example.ejb;

import static com.example.Common.ENABLED;
import static com.example.Common.TRACE_REQUEST_PENDING;

import datadog.trace.api.Trace;
import javax.ejb.Schedule;
Expand All @@ -11,7 +11,7 @@ public class ScheduledEjb {

@Schedule(second = "*/1", minute = "*", hour = "*")
public void runIt() {
if (ENABLED.getAndSet(false)) {
if (TRACE_REQUEST_PENDING.getAndSet(false)) {
generateSomeTrace();
}
}
Expand Down
7 changes: 4 additions & 3 deletions dd-smoke-tests/wildfly/spring-ear/war/src/main/java/com/example/hello/HelloController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.example.hello;

import static com.example.Common.ENABLED;
import static com.example.Common.TRACE_REQUEST_PENDING;

import java.util.concurrent.CompletableFuture;
import org.springframework.http.ResponseEntity;
Expand All @@ -17,10 +17,11 @@ public String hello() {

@RequestMapping("/enableScheduling")
public CompletableFuture<ResponseEntity<Void>> enableScheduling() {
ENABLED.set(true);
TRACE_REQUEST_PENDING.set(true);
return CompletableFuture.supplyAsync(
() -> {
while (!ENABLED.get()) {
// Wait until the scheduled task picks up the request.
while (TRACE_REQUEST_PENDING.get()) {
try {
Thread.sleep(200);
} catch (InterruptedException e) {
Expand Down