Preserve captured response body when AppSec response hook fails

[dougqh]

What Does This Do

Wraps the publish() call for the AppSec response hook inside AppSecInterceptor.onResponse() in its own try/catch (matching the existing pattern for the request-hook path), so a non-blocking exception from the response hook no longer discards the already-rebuilt response.

Motivation

onResponse() rebuilds the response with the body it captured for AppSec analysis into a local result. If the response hook (publish()) then threw an exception other than BlockingException, that exception propagated out of onResponse() and intercept()'s outer catch fell back to the original response object — whose body had already been consumed reading it into result. Callers ended up seeing an empty/closed body instead of the real one.

Stacked on #12242, which fixed a related NPE (span.getTag(Tags.HTTP_URL) risk) flagged during the same review pass on that PR.

Additional Notes

• Applied identically to both okhttp-2.2 and okhttp-3.0 instrumentation modules.
• Added responseHookFailureAfterBodyCapturePreservesCapturedBody to AppSecInterceptorTest in both modules, verifying the response body survives a throwing response hook.
• Existing AppSecInterceptorTest suites pass for both modules; ./gradlew spotlessApply run.
• /techdebt and /perf-review run over the branch diff: no findings.

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

[datadog-prod-us1-5]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 69.74% (+0.00%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 04ae7fb | Docs | View more details | Give us feedback!}

[datadog-prod-us1-5]

More details

The new catch keeps the rebuilt response when the AppSec hook fails. It does not catch BlockingException.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit 04ae7fb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.71 s	14.64 s	[-0.2%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent	13.71 s	13.72 s	[-0.7%; +0.6%] (no difference)
startup:petclinic:appsec:Agent	17.56 s	17.30 s	[+0.6%; +2.5%] (maybe worse)
startup:petclinic:iast:Agent	17.44 s	17.01 s	[-2.0%; +7.0%] (no difference)
startup:petclinic:profiling:Agent	17.36 s	17.28 s	[-0.9%; +1.8%] (no difference)
startup:petclinic:sca:Agent	17.43 s	17.33 s	[-0.5%; +1.6%] (no difference)
startup:petclinic:tracing:Agent	16.37 s	16.21 s	[-3.4%; +5.4%] (no difference)

Commit: 04ae7fbc · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.