fix(next): preserve http endpoint for parent spans - #9682
Merged
Conversation
Contributor
Overall package sizeSelf size: 7.83 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 441.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a953ec306e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4347d5f3c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9682 +/- ##
========================================
Coverage 98.52% 98.52%
========================================
Files 957 957
Lines 135106 135116 +10
Branches 12015 11721 -294
========================================
+ Hits 133109 133120 +11
+ Misses 1997 1996 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-08-04 18:38:34 Comparing candidate commit fe4763c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2317 metrics, 41 unstable metrics.
|
bojbrook
requested changes
Aug 4, 2026
bojbrook
left a comment
bojbrook
left a comment
Contributor
There was a problem hiding this comment.
Looks good, The two codex comments should be addressed before merging this.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34f2a71e85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d659fadf6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0a6f8235a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
* fix(next): preserve http endpoint for parent spans * test(next): cover compiled HTTP endpoint tagging * fix(next): gate parent endpoint tagging * fix(next): preserve HTTP endpoint ownership * fix(next): retain HTTP request for compiled routes * fix(next): retain compiled route HTTP context * test(next): exercise compiled route HTTP context * test(next): remove unused tracer reference * test(next): configure HTTP endpoint coverage * fix(web): release completed request mappings
Merged
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
* fix(next): preserve http endpoint for parent spans * test(next): cover compiled HTTP endpoint tagging * fix(next): gate parent endpoint tagging * fix(next): preserve HTTP endpoint ownership * fix(next): retain HTTP request for compiled routes * fix(next): retain compiled route HTTP context * test(next): exercise compiled route HTTP context * test(next): remove unused tracer reference * test(next): configure HTTP endpoint coverage * fix(web): release completed request mappings
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Aug 5, 2026
* fix(next): preserve http endpoint for parent spans * test(next): cover compiled HTTP endpoint tagging * fix(next): gate parent endpoint tagging * fix(next): preserve HTTP endpoint ownership * fix(next): retain HTTP request for compiled routes * fix(next): retain compiled route HTTP context * test(next): exercise compiled route HTTP context * test(next): remove unused tracer reference * test(next): configure HTTP endpoint coverage * fix(web): release completed request mappings
juan-fernandez
pushed a commit
that referenced
this pull request
Aug 5, 2026
* fix(next): preserve http endpoint for parent spans * test(next): cover compiled HTTP endpoint tagging * fix(next): gate parent endpoint tagging * fix(next): preserve HTTP endpoint ownership * fix(next): retain HTTP request for compiled routes * fix(next): retain compiled route HTTP context * test(next): exercise compiled route HTTP context * test(next): remove unused tracer reference * test(next): configure HTTP endpoint coverage * fix(web): release completed request mappings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.endpointtag when compiled Next runtimes refine the HTTP parent routeVerification
TRACING_CONFIG_NONDEFAULT_3/test_http_endpoint_rootagainst the real Next 14.0.4 appassert None == "/"http.endpoint: "/"andhttp.route: "/"Focused ESLint could not run locally because the shared dependency tree has an incompatible
eslint-plugin-unicornversion for the current config; CI will validate lint.