Skip to content

Add dd-octo-sts trust policy for images-rb cross-repo dispatch - #6154

Merged
TonyCTHsu merged 5 commits into
masterfrom
fix/update-images-sts-policy
Aug 5, 2026
Merged

Add dd-octo-sts trust policy for images-rb cross-repo dispatch#6154
TonyCTHsu merged 5 commits into
masterfrom
fix/update-images-sts-policy

Conversation

@TonyCTHsu

@TonyCTHsu TonyCTHsu commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Change log entry

None.

@TonyCTHsu
TonyCTHsu requested a review from a team as a code owner August 5, 2026 13:28
@dd-octo-sts

dd-octo-sts Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for updating Change log entry section 👏

Visited at: 2026-08-05 13:30:22 UTC

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Aug 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9b163d215

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/chainguard/images-rb.notify-consumers.sts.yaml
Comment thread .github/chainguard/images-rb.notify-consumers.sts.yaml Outdated
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Aug 5, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.04% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 669ee94 | Docs | Datadog PR Page | Give us feedback!

images-rb's notify-consumers.yml needs a token scoped to this repo to
call repository_dispatch after a successful build. It cannot use
self.update-images: that policy's subject/claim_pattern describe this
repo's own update-images.yml authenticating to open the pin PR, a
different caller identity. Matches images-rb's real OIDC claims
(subject repo:DataDog/images-rb:ref:refs/heads/main, job_workflow_ref
DataDog/images-rb/.github/workflows/notify-consumers.yml@refs/heads/main)
for both its workflow_run and workflow_dispatch triggers, and grants
only contents: write, the sole permission the dispatch API requires.
The cross-repo grant is an ordinary in-repo dd-octo-sts trust policy
file (images-rb.notify-consumers.sts.yaml), not an externally
provisioned grant as previously documented.
notify-consumers.yml's workflow_dispatch trigger can run from any
branch to send an early pin-update dispatch before merging to main,
per its own documented behavior. The policy previously restricted the
subject and job_workflow_ref to refs/heads/main only, which would
silently deny token exchange for that manual pre-merge path.
@TonyCTHsu
TonyCTHsu force-pushed the fix/update-images-sts-policy branch from f515cdc to 38a9046 Compare August 5, 2026 13:56
@pr-commenter

pr-commenter Bot commented Aug 5, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-05 14:22:55

Comparing candidate commit 38a9046 in PR branch fix/update-images-sts-policy with baseline commit e425098 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:tracing - trace.to_digest - Continue

  • unstable throughput [-1412.737op/s; +1629.616op/s] or [-4.830%; +5.572%]

Comment thread AGENTS.md Outdated
Co-authored-by: Sergey Fedorov <oni.strech@gmail.com>
@TonyCTHsu
TonyCTHsu enabled auto-merge August 5, 2026 23:23
@TonyCTHsu
TonyCTHsu merged commit ef94451 into master Aug 5, 2026
330 checks passed
@TonyCTHsu
TonyCTHsu deleted the fix/update-images-sts-policy branch August 5, 2026 23:47
@dd-octo-sts dd-octo-sts Bot added this to the 2.41.0 milestone Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/tooling Involves tools (e.g. Rubocop, CodeCov)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants