Add dd-octo-sts trust policy for images-rb cross-repo dispatch - #6154
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2026-08-05 13:30:22 UTC |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9b163d215
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 669ee94 | Docs | Datadog PR Page | Give us feedback! |
images-rb's notify-consumers.yml needs a token scoped to this repo to call repository_dispatch after a successful build. It cannot use self.update-images: that policy's subject/claim_pattern describe this repo's own update-images.yml authenticating to open the pin PR, a different caller identity. Matches images-rb's real OIDC claims (subject repo:DataDog/images-rb:ref:refs/heads/main, job_workflow_ref DataDog/images-rb/.github/workflows/notify-consumers.yml@refs/heads/main) for both its workflow_run and workflow_dispatch triggers, and grants only contents: write, the sole permission the dispatch API requires.
The cross-repo grant is an ordinary in-repo dd-octo-sts trust policy file (images-rb.notify-consumers.sts.yaml), not an externally provisioned grant as previously documented.
notify-consumers.yml's workflow_dispatch trigger can run from any branch to send an early pin-update dispatch before merging to main, per its own documented behavior. The policy previously restricted the subject and job_workflow_ref to refs/heads/main only, which would silently deny token exchange for that manual pre-merge path.
f515cdc to
38a9046
Compare
BenchmarksBenchmark execution time: 2026-08-05 14:22:55 Comparing candidate commit 38a9046 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.
|
Co-authored-by: Sergey Fedorov <oni.strech@gmail.com>
Summary
Change log entry
None.