Fix WaterDrop propagation with frozen headers - #6182
Open
vicentereig wants to merge 4 commits into
Open
Conversation
This was referenced Aug 12, 2026
vpellan
reviewed
Aug 13, 2026
vpellan
left a comment
vpellan
left a comment
Contributor
There was a problem hiding this comment.
Hello! Thanks for your contribution, I've left some comments, I will start the CI and if everything is green, I'll approve and merge the PR
vpellan
reviewed
Aug 13, 2026
Co-authored-by: Victor Pellan <37553749+vpellan@users.noreply.github.com>
Author
|
@vpellan You got it, I appreciate your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WaterDrop can receive frozen header hashes from rdkafka consumer messages. The WaterDrop integration currently mutates that hash when distributed tracing or DSM propagation is enabled, which raises FrozenError.
Copy the headers once before either propagation path runs. This preserves the caller-owned hash and keeps the outbound hash mutable.
Testing
This patch was prepared with coding-agent assistance. I reviewed the implementation and tests and verified the reproduction.