[FFL-2914] Add targeting regex conformance fixture - #21
Merged
btthomas merged 12 commits intoAug 14, 2026
Conversation
btthomas
force-pushed
the
blake.thomas/FFL-2914-pr0-regex-conformance-fixture
branch
from
August 7, 2026 13:02
58d62fd to
705f54a
Compare
btthomas
marked this pull request as ready for review
August 7, 2026 14:33
btthomas
requested review from
dd-oleksii and
pavlokhrebto
and removed request for
a team
August 7, 2026 14:33
Bring PR #21 onto the shared fixture validation and downstream compatibility workflows. Environment: Datadog workspace
leoromanovsky
added a commit
that referenced
this pull request
Aug 10, 2026
Refresh the evidence-only stack after merging main into PR #21 and isolate the regex audit from the canonical compatibility workflow.\n\nEnvironment: Datadog workspace
# Conflicts: # CONTRIBUTING.md
btthomas
deleted the
blake.thomas/FFL-2914-pr0-regex-conformance-fixture
branch
August 14, 2026 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FFL-2914 needs one shared set of targeting regex examples before Go, Rust, and web-ui add validation. Without a shared contract, those implementations can accept different patterns or return different match results.
This PR adds test data, documentation, and CI validation only. It does not change production behavior. It is PR0 from the branch strategy and follows the implementation plan.
Changes
FFE regex authoring contract
4f8ef95faec9faa3c2b0756ac61afe862e35c0646cba5375532a85335f209e8f.regexp, RE2JS, the Rust rules-based evaluator, and the Rust rkyv evaluator.SDK evaluation data
a{1,3}remains one regex value.regex-flag; invalid syntax remains covered by the standalone contract.Downstream compatibility preview
Decisions
regex-conformance/, notevaluation-cases/. Existing consumers read every JSON file inevaluation-cases/as a complete UFC evaluation case.evaluation-cases/. These cases useufc-config.jsonand the normal SDK evaluation schema.regexp, RE2JS, the Rust rules-based evaluator, and the Rust rkyv evaluator.]classes are rejected because at least one shipped SDK cannot evaluate them consistently.Pattern, JavaScriptRegExp, and .NETRegexare not represented byengineExpectations; the focused downstream checks provide the accepted-case evidence for those evaluators.Downstream dd-source changes must wait until this PR is merged into
mainbefore pinning the new fixture commit.Customer remediation before enforcement
The newly rejected syntax is valid in some current evaluators, so existing customer configurations may already use it. Before dd-source enables strict write validation, the release owner must audit active allocations, saved filters, pending suggestions, and published or locked protocol templates for the five newly rejected syntax families.
The audit must report identifiers and counts without regex values. The owning team must review each result with the customer or support owner and edit or delete the affected regex or targeting rule before enforcement. If safe remediation is not complete, backend enforcement must wait or the implementation plan must define an explicit compatibility policy.
Validation
Results:
Checklist
regex-flaginufc-config.json.