Skip to content

test: add semver validation fixtures - #22

Merged
btthomas merged 2 commits into
DataDog:mainfrom
greghuels:greg.huels/semver-validation-fixtures
Aug 6, 2026
Merged

test: add semver validation fixtures#22
btthomas merged 2 commits into
DataDog:mainfrom
greghuels:greg.huels/semver-validation-fixtures

Conversation

@greghuels

@greghuels greghuels commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • verify that build metadata is ignored for SemVer precedence: 4.5.6-rc.1+build.42 matches SEMVER_EQ 4.5.6-rc.1 instead of falling through to SEMVER_GT
  • directly cover the build-metadata behavior called out in dd-trace-go review feedback
  • add Rust-compatible uint64 boundary and strict parsing fixtures
  • cover arbitrarily large numeric prerelease identifiers and invalid configured comparands

Validation

  • jq empty ufc-config.json evaluation-cases/*.json
  • go test ./openfeature in DataDog/dd-trace-go

@greghuels
greghuels requested a review from a team as a code owner August 5, 2026 13:25
@greghuels
greghuels requested review from btthomas and dd-oleksii and removed request for a team August 5, 2026 13:25
Comment thread evaluation-cases/test-case-semver-validation-flag.json
Comment thread evaluation-cases/test-case-semver-validation-flag.json Outdated
- Remove u64-overflow test cases (major/minor/patch-overflow, large-prerelease): semver does not limit component range so these cannot be universally declared invalid
- Replace u64 max comparand with Number.MAX_SAFE_INTEGER (9007199254740991) for the max-core test case and flag allocation, keeping a cross-SDK-safe boundary test
- Drop "Rust SemVer" from short-version and v-prefix descriptions; these are standard semver rules

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@greghuels
greghuels requested a review from dd-oleksii August 5, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants