chore(ci): add blocking cargo-deny bans gate - #2387
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intoAug 21, 2026
Merged
chore(ci): add blocking cargo-deny bans gate#2387gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
Conversation
This reverts commit b52da22.
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 0fcf3c3 | Docs | View more details | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d9c8f0ccc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+378
to
+379
| cargo-deny-bans: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
When a PR targets the release branch, this entire workflow is suppressed by branches-ignore at lines 8–10, so the new job never runs. Such a PR can therefore change Cargo.lock to include a banned or compromised crate without receiving the intended blocking check; move this gate to a workflow that covers release targets or narrow the exclusions for this job.
AGENTS.md reference: AGENTS.md:L46-L50
Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment.
fixed by creating a separate workflow
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
gyuheon0h
approved these changes
Aug 20, 2026
bantonsson
approved these changes
Aug 21, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
ekump/APMSP-3945-gate-on-cargo-deny-bans
branch
August 21, 2026 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a new CI step to prevent merging PRs on the cargo deny ban list.
We already run cargo deny and comment on PRs with warning and advisories. There is ongoing work to address the advisories and warnings, but we don't necessarily want to gate on them at the moment.
We absolutely do want to gate on banned crates right now. This PR introduces a step independent from the existing cargo deny step and is always-on (unlike the existing cargo deny step which only checks impacted crates).
Motivation
https://safedep.io/arrayref-proc-macro1-rust-build-time-malware/
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.