Auto-activate ruby easy wins for feature-flagging-and-experimentation-sdk - #7044
Auto-activate ruby easy wins for feature-flagging-and-experimentation-sdk#7044dd-octo-sts[bot] wants to merge 1 commit into
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3979338806
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV2::test_tracing_client_tracing_tags: missing_feature # Created by easy win activation script | ||
| tests/parametric/test_ffe/test_dynamic_evaluation.py::Test_Feature_Flag_Dynamic_Evaluation: v2.23.0 | ||
| tests/parametric/test_ffe/test_span_enrichment.py: missing_feature | ||
| tests/parametric/test_ffe/test_span_enrichment.py: '>=2.34.0' # TODO: a lower version might be supported |
There was a problem hiding this comment.
Keep subject-limit tests disabled until they assert enrichment
With this file-level activation, Test_Span_Enrichment_Max_Subjects is now enabled for Ruby because it is the only subject-enrichment class not listed below as missing_feature. I checked tests/parametric/test_ffe/test_span_enrichment.py: test_max_10_subjects_enforced only validates the limit inside if "ffe_subjects_enc" in meta, so Ruby can emit no ffe_subjects_enc at all and still pass, while the adjacent subject-enrichment classes remain marked unsupported. This makes the easy-win activation report subject enrichment support even when the tracer does not provide it; either keep this class disabled too or make the test fail when the tag is absent.
Useful? React with 👍 / 👎.
3979338 to
4b25bc5
Compare
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
|
b17e181 to
dcf775a
Compare
dcf775a to
e57ae82
Compare
new commit added, dismiss all previous approvals
e57ae82 to
57e452d
Compare
new commit added, dismiss all previous approvals
57e452d to
bc748af
Compare
new commit added, dismiss all previous approvals
bc748af to
bbb9894
Compare
new commit added, dismiss all previous approvals
…tation-sdk Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bbb9894 to
db3d9ba
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
rubyowned byfeature-flagging-and-experimentation-sdkView nightly workflow run