Auto-activate rust easy wins for apm-sdk-capabilities - #7242
Auto-activate rust easy wins for apm-sdk-capabilities#7242dd-octo-sts[bot] wants to merge 1 commit into
Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7f891f63d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| component_version: <0.4.1-dev+83c985c | ||
| tests/parametric/test_otel_logs.py::Test_FR13_Scope_Fields::test_scope_schema_url_field: missing_feature (OpenTelemetry Rust SDK limitation - schema_url not exported by opentelemetry-otlp) | ||
| tests/parametric/test_otel_logs.py::Test_FR13_Scope_Fields::test_scope_version_field: missing_feature (OpenTelemetry Rust SDK limitation - scope version not exported by opentelemetry-otlp) | ||
| tests/parametric/test_otel_logs.py::Test_FR13_Scope_Fields::test_scope_version_field: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (OpenTelemetry Rust SDK limitation - scope version not exported by opentelemetry-otlp) | ||
| component_version: <0.4.1-dev+83c985c |
There was a problem hiding this comment.
When Rust is tested from a git checkout, utils/build/docker/rust/install_ddtrace.sh builds versions as 0.4.1-dev+<short-sha>, but the <0.4.1-dev+83c985c range is a SemVer comparison over build metadata/a git SHA, not a chronological commit boundary. For any dd-trace-rs branch before the fix whose SHA sorts after 83c985c (or a later one sorting before it), these two tests will be incorrectly activated or skipped, so this should stay disabled until a real release/version boundary rather than using the commit hash in the range.
Useful? React with 👍 / 👎.
f7f891f to
6d04c5d
Compare
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
6d04c5d to
299fbcd
Compare
new commit added, dismiss all previous approvals
299fbcd to
f675ab8
Compare
new commit added, dismiss all previous approvals
f675ab8 to
00fa6f3
Compare
new commit added, dismiss all previous approvals
00fa6f3 to
40d1885
Compare
new commit added, dismiss all previous approvals
40d1885 to
63e468a
Compare
new commit added, dismiss all previous approvals
63e468a to
4471cfc
Compare
new commit added, dismiss all previous approvals
4471cfc to
d1e1d98
Compare
new commit added, dismiss all previous approvals
d1e1d98 to
47c7f5a
Compare
0a015c4 to
7fc1b3d
Compare
new commit added, dismiss all previous approvals
7fc1b3d to
12f9379
Compare
new commit added, dismiss all previous approvals
12f9379 to
b4821e8
Compare
new commit added, dismiss all previous approvals
b4821e8 to
88a7a1d
Compare
new commit added, dismiss all previous approvals
88a7a1d to
8f80ecc
Compare
new commit added, dismiss all previous approvals
8f80ecc to
4e377c2
Compare
new commit added, dismiss all previous approvals
4e377c2 to
d79f2f1
Compare
new commit added, dismiss all previous approvals
d79f2f1 to
6ebf54e
Compare
new commit added, dismiss all previous approvals
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6ebf54e to
568ffb6
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
rustowned byapm-sdk-capabilitiesView nightly workflow run